sp_PerfCheck Phase 1: cut noise, flag bad config not changed config - #836
Merged
Conversation
The check set drowned real findings in priority-50 checklist noise and had some logic backwards. On a normal server this cut a 27-finding run to 10, all meaningful. Deleted, none of which indicate a problem: - 7005 ANSI Settings Require Review (fired on every database; the SESSION SET options the driver sends are what matter, not database-level ANSI) - 7007 Non-Default Target Recovery Time - 4107 Resource Governor Enabled (bare "it is on" informational) - 1000 Non-Default Configuration, the generic "changed from default" list -- it flagged correct MAXDOP / cost threshold / max memory values as findings Inverted the cost-threshold check (1004) to flag the BAD value instead of the changed one: it now fires when CTFP is under 50, escalating to High (20) at or below the terrible default of 5 and staying Low (40) between 6 and 49. Kept 7103 (log growth <> 64 MB) -- it looks like a nitpick but is a real SQL 2022 check: log auto-growth only gets instant file initialization at 64 MB. Reworked the harness config test to match: it now forces CTFP sane / default / low and asserts absence, presence, and the priority escalation bidirectionally. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass of making sp_PerfCheck actually useful: kill the checklist noise and invert the backwards config logic. On a normal server this takes a 27-finding run down to 10, all meaningful.
Deleted (none indicate a problem)
Inverted
Kept
Harness
Reworked the config test for the inverted CTFP semantics (absent when sane, present + High at default, present + Low when 6–49), bidirectional with restore. 39/39 local; compiles on all five versions.
🤖 Generated with Claude Code