Skip to content

db/state/execctx: fix AccountsDomain codeHash decode (DeserialiseV3) — correctness #21623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mh0lt wants to merge 1 commit into from
Closed

db/state/execctx: fix AccountsDomain codeHash decode (DeserialiseV3) — correctness #21623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion db/state/execctx/domain_shared.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,7 +1121,12 @@ func decodeAccountCodeHash(enc []byte) []byte {
return nil
}
var acc accounts.Account
if err := acc.DecodeForStorage(enc); err != nil {
// AccountsDomain values are SerialiseV3-encoded, so they must be decoded
// with DeserialiseV3. DecodeForStorage is the legacy MDBX bitmask format
// with an incompatible binary layout; applied to V3 bytes it silently
// misparses and leaves CodeHash empty, so codeHashForAddr returned nil for
// every contract and the CodeDomain ethHash bypass never fired.
if err := accounts.DeserialiseV3(&acc, enc); err != nil {
return nil
}
if acc.CodeHash.IsEmpty() {
Expand Down
Loading