Open
Conversation
added 26 commits
March 19, 2021 00:13
erickwize
previously approved these changes
Mar 24, 2021
Owner
erickwize
left a comment
There was a problem hiding this comment.
Comments
I can see you started to create some tests for the components using enzyme and it is ok, but we encourage you to use React Testing Library.
I have the same recommendation of creating the PR into your own Github repo so we can merge it when it is approved or done.
Also please add a file with the coverage of the tests for the following deliverables.
Acceptance Criteria
- Meaningful test cases were implemented for components and sub-routines logic.
- All the test cases were successful.

It failed only a snapshot (not a big deal - you can update it with the new UI)
Bonus Points
- Test coverage is above 60%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mini-Challenge 2: Intro to Testing
Answer the following questions first
1. Using
create-react-app, what do we need to set up for testing?2. What components are worth testing in your development?
3. Can you apply TDD once you already created components?
The Challenge
Acceptance Criteria
Bonus Points