fix(sort): Fixing sorting issues in torrent list view (fixes #304)#686
Open
tejas-rkd wants to merge 1 commit intoerickok:masterfrom
Open
fix(sort): Fixing sorting issues in torrent list view (fixes #304)#686tejas-rkd wants to merge 1 commit intoerickok:masterfrom
tejas-rkd wants to merge 1 commit intoerickok:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The implemented changes address two key user experience issues with the sort functionality: (fixes #304)
Solution
1. Radio Button Highlighting
Added proper selection state management to ensure the currently active sort option is visually indicated with a radio button:
onCreateOptionsMenu()to initialize the selected sort option based on the user's last selectionupdateSortMenuSelection()to manage the checked states across all menu items2. Sort Direction Indication
Created a visual indicator for sort direction by rotating the sort icon:
ic_action_sort_asc.xml) for descending orderTesting
Demo Link: https://drive.google.com/file/d/1vrV5PFoD7OInxs3mIR93doYdfAJRbyBS/view?usp=drivesdk
statusandDescending)