Repository navigation
CI uploads the AppTests coverage to Codecov under the app flag (#679) - #973
Merged
Merged
Conversation
The macOS leg's App tests step now records coverage and a report-only step sends the app's lcov with flags: app. Packages/ is left out, since the Kit reports its own under kit. An upload problem never fails CI. Assisted-by: Claude Code:claude-sonnet-5-5
Skeyelab
enabled auto-merge (squash)
October 27, 2026 04:48
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #679 (upload only; record screen glue tests wait on #552).
-enableCodeCoverage YES.kit) and uploads it withflags: app.continue-on-error, andfail_ci_if_error: false.preflight.shandrelease.ymlare untouched, so none of them build AppTests.project.ymland the scheme are unchanged.Red/green: before, no
build/dd/Build/ProfileDataexisted after a plain test run; with the flag, the same commands give a profile and an lcov with 34 App/ files and no Packages/ files (checked locally). Whether Codecov shows theappflag with a number is checked only on this PR's run; I have not seen it yet.Review: Code Reviewer pass applied (upload
continue-on-error, fallback to the plain binary if the debug dylib is missing). Left as is: the extra recompile from the coverage flag.