Repository navigation
The Trial status sheet names the upgrade's price for a pack owner (#968) - #970
Merged
Merged
Conversation
Since #967 the sheet's button offers a pack owner the upgrade, but the notice above it still read "Pro is a one-time purchase of <full price>". TrialStatusNotice takes an upgrade flag, and the sheet passes the offered product's price, so the line reads "The upgrade to Pro is a one-time purchase of <upgrade price>". Everyone else reads what they read before. Assisted-by: Claude Code:claude-opus-5-5
Skeyelab
enabled auto-merge (squash)
October 27, 2026 03:16
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #968.
For a pack owner, the Trial status sheet's notice line now reads "The upgrade to Pro is a one-time purchase of , shared with your family. Nothing is charged when the Trial ends." It matches the upgrade button below it (#967).
TrialStatusNoticegetsupgrade: Bool = false, and the sheet passes the price of the product it offers. Until that product loads, the price line is left out, as before. Everyone without a bought pack reads exactly what they read before."Shared with your family" holds for the upgrade: CONTEXT.md's #705 notes and the StoreKit config (
familyShareable: true) say so. Family Sharing has to be turned on when the product is created in App Store Connect (#857).Tests (RecordingTests/TrialTests)
statusNoticeForAPackOwner: red first, with the flag added but unused:✘ ... TrialTests.swift:96:9: Expectation failed: text.contains("The upgrade to Pro is a one-time purchase of $12.00"). The second expectation in that first run was wrongly written: the upgrade line contains "Pro is a one-time purchase of", so it could never pass. It now checks that no line starts with "Pro is".statusNoticehas an added check that the default line still starts with "Pro is a one-time purchase of $19.99". It passed on its first run.Full
./scripts/verify.shpassed: package tests, macOS build and AppTests, iOS Simulator build, 151s. After a test-only check and a comment rewrap, the package tests andVERIFY_QUICK=1passed again.Not checked or left out
TrialDisclosure(the App Review 3.1.1 text in TrialSheet) still names the full Pro price to a pack owner. It's the same mismatch, but it is review copy, so it's left for its own issue.