Skip to content

Add standalone macro editor page#38

Draft
IgorArkhipov wants to merge 1 commit into
ergohaven:mainfrom
IgorArkhipov:igor/standalone-macro-editor
Draft

Add standalone macro editor page#38
IgorArkhipov wants to merge 1 commit into
ergohaven:mainfrom
IgorArkhipov:igor/standalone-macro-editor

Conversation

@IgorArkhipov

@IgorArkhipov IgorArkhipov commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

EN

Summary

  • Adds a standalone Macros page to the Settings dropdown when the connected keyboard exposes macro slots.
  • Reuses the existing macro editor so macros can be selected, viewed, and edited without assigning the macro to a key.
  • Splits macro editor commit behavior so the key picker still assigns M<n>, while the standalone page saves without changing the currently selected keycode.

Verification

  • git diff --check
  • /Users/igor.arkhipov/.cargo/bin/cargo build --quiet
  • /Users/igor.arkhipov/.cargo/bin/cargo test --quiet passes: 46 tests.

RU

Кратко

  • Добавляет отдельную страницу Macros в меню настроек, если подключенная клавиатура поддерживает макросы.
  • Переиспользует существующий редактор макросов, чтобы макросы можно было выбирать, просматривать и редактировать без назначения макроса на клавишу.
  • Разделяет поведение сохранения: пикер клавиш по-прежнему назначает M<n>, а отдельная страница сохраняет макрос без изменения выбранного keycode.

Проверка

  • git diff --check
  • /Users/igor.arkhipov/.cargo/bin/cargo build --quiet
  • /Users/igor.arkhipov/.cargo/bin/cargo test --quiet проходит: 46 тестов.

@IgorArkhipov
IgorArkhipov force-pushed the igor/standalone-macro-editor branch from ca68b8b to 4cf3cc4 Compare June 27, 2026 18:55
@IgorArkhipov

Copy link
Copy Markdown
Contributor Author

Rebased this branch onto current origin/main.

The conflict in src/keycode_picker_macro.rs was only in the test module, so I kept the lossless macro bytecode round-trip coverage from #32 together with this PR’s standalone macro editor commit-mode tests.

The PR is now clean against main and CI is green (4/4).

@kissetfall

Copy link
Copy Markdown
Member

Thanks. Keeping this one open, but not merging it for now. The standalone macro editor is still a product question for us: we may add it later, but we would prefer to avoid a separate page if we can keep the macro workflow simple enough inside the existing picker/settings structure.

@IgorArkhipov
IgorArkhipov marked this pull request as draft June 28, 2026 03:33
@IgorArkhipov
IgorArkhipov force-pushed the igor/standalone-macro-editor branch from 4cf3cc4 to 9286df9 Compare June 29, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants