Crash in sp_speed#1148
Merged
Merged
Conversation
may not return a target. mindblast requires special exception code, since size of the target unit is required.
but not the iwyu on erdbaer? what version is this, github?
iwyu 0.21 seems to be active
ennorehling
force-pushed
the
tactics_crash
branch
from
3da4091 to
a7a4407
Compare
this should have a test
ennorehling
added a commit
that referenced
this pull request
Jul 4, 2026
* Crash in sp_speed (#1148) * combat spells must handle new select_enemy behavior may not return a target. mindblast requires special exception code, since size of the target unit is required. * fix select_enemy for loot and test * github's iwyu says I don't need these headers. but not the iwyu on erdbaer? what version is this, github? * reorder steps * fix version commands in action iwyu 0.21 seems to be active * fix bug in escape_tactics this should have a test * merge error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in tactics turn, select_enemy can return a NULL fighter.