Skip to content

Add endpoint for available analysis#423

Merged
akustn merged 2 commits into
equinor:mainfrom
akustn:add-analysis-to-inspection
Jun 26, 2026
Merged

Add endpoint for available analysis#423
akustn merged 2 commits into
equinor:mainfrom
akustn:add-analysis-to-inspection

Conversation

@akustn

@akustn akustn commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes backend part of #378

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like logging, TODO, etc.
  • The PR has been tested locally
  • A test has been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that requires new issues
  • The changes do not introduce dead code as unused imports, functions etc.

@akustn akustn force-pushed the add-analysis-to-inspection branch from bb2db58 to 221b19f Compare June 25, 2026 09:11
@akustn akustn self-assigned this Jun 25, 2026
@akustn akustn added good first issue Good for newcomers feature New feature or request labels Jun 25, 2026
@akustn akustn force-pushed the add-analysis-to-inspection branch 4 times, most recently from c7cd8ed to 1bbcdca Compare June 26, 2026 08:29
@akustn akustn marked this pull request as ready for review June 26, 2026 09:13
@akustn akustn linked an issue Jun 26, 2026 that may be closed by this pull request
Add ability to add new analyses to existing inspection records #378
Closed
@akustn akustn requested a review from aeshub June 26, 2026 10:15
oysand
oysand approved these changes Jun 26, 2026
View reviewed changes

@oysand oysand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

andchiind
andchiind approved these changes Jun 26, 2026
View reviewed changes

@andchiind andchiind left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

Comment thread api/Controllers/AnalysisController.cs Outdated
[Authorize(Roles = Role.Any)]
[Route("available")]
[ProducesResponseType(StatusCodes.Status200OK)]
public async Task<IActionResult> GetAvailableAnalyses()

@andchiind andchiind Jun 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public async Task<IActionResult> GetAvailableAnalyses()
public async Task<IActionResult<List<string>>> GetAvailableAnalyses()

@akustn akustn force-pushed the add-analysis-to-inspection branch from 1bbcdca to 6cb7477 Compare June 26, 2026 11:08
@akustn akustn merged commit 89dfeea into equinor:main Jun 26, 2026
8 checks passed
@akustn akustn deleted the add-analysis-to-inspection branch June 26, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andchiind andchiind andchiind approved these changes
@oysand oysand oysand approved these changes
@aeshub aeshub Awaiting requested review from aeshub

Assignees

@akustn akustn

Labels

feature New feature or request good first issue Good for newcomers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ability to add new analyses to existing inspection records

3 participants

@akustn @andchiind @oysand