Attempt to auto-detect TIRPC=YES#187
Attempt to auto-detect TIRPC=YES#187mdavidsaver wants to merge 2 commits intoepics-modules:masterfrom
Conversation
BESSY repo is offline...
|
✅ Build asyn 1.0.240 completed (commit 3539991644 by @mdavidsaver) |
|
The Asyn build currently assumes that TIRPC is only needed on Linux, although that doesn't mean other OSs won't ever switch to that in the future. I approve of adding and installing a However static builds of those downstream applications won't necessarily know about tirpc if they don't call it directly (the synApps SSCAN module does, I've had to add a TIRPC flag to that for our RHEL-8 builds), but they will need to know whether to link their executables with the |
Yup, I know. I see this PR as a first small step towards dealing with a complication which has perhaps become the number one new user obstacle reported on tech-talk. (maybe a close second to CA timeout due to firewall) fyi. I have to confront a similar situation with static linking wrt. libevent in the PVXS build. cf. CONFIG_PVXS_MODULE and |
|
I am also thinking about ways to give a better error when #ifdef __has_include
# if !__has_include(<rpc/rpc.h>)
# error Missing rpc/rpc.h. Try "apt-get install libtirpc-dev" or "dnf install tirpc-devel"
# endif
#endif |
|
Also, I feel bound to point out that this PR, and any which may follow, are in effect re-inventing functionality which is present in all ~modern C/C++ build tools. Anything I do here will almost certainly be less comprehensive than eg. cmake |
Attempts to detect when
TIRPC=YESis needed. Currently only in the limited case where the host architecture is Linux.Also, remove SNCSEQ from the CI builds as the BESSY site is still offline.