Skip to content

Fix double application of FillAlpha in shaded plots #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinecker wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix double application of FillAlpha in shaded plots #717

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions implot_items.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1929,7 +1929,7 @@ void PlotLineEx(const char* label_id, const _Getter& getter, const ImPlotSpec& s
RenderPrimitives3<RendererShaded>(getter,getter2,color_getter);
} else {
const ImU32 col_fill = ImGui::GetColorU32(s.Spec.FillColor);
GetterConstColor color_getter(col_fill, s.Spec.FillAlpha);
GetterConstColor color_getter(col_fill);
RenderPrimitives3<RendererShaded>(getter,getter2,color_getter);
}
}
Expand Down Expand Up @@ -2200,15 +2200,15 @@ void PlotStairsEx(const char* label_id, const Getter& getter, const ImPlotSpec&
GetterIdxColor color_getter(s.Spec.FillColors, getter.Count, s.Spec.FillAlpha);
RenderPrimitives2<RendererStairsPreShaded>(getter, color_getter);
} else {
GetterConstColor color_getter(col_fill, s.Spec.FillAlpha);
GetterConstColor color_getter(col_fill);
RenderPrimitives2<RendererStairsPreShaded>(getter, color_getter);
}
} else {
if (s.Spec.FillColors != nullptr) {
GetterIdxColor color_getter(s.Spec.FillColors, getter.Count, s.Spec.FillAlpha);
RenderPrimitives2<RendererStairsPostShaded>(getter, color_getter);
} else {
GetterConstColor color_getter(col_fill, s.Spec.FillAlpha);
GetterConstColor color_getter(col_fill);
RenderPrimitives2<RendererStairsPostShaded>(getter, color_getter);
}
}
Expand Down Expand Up @@ -2286,7 +2286,7 @@ void PlotShadedEx(const char* label_id, const Getter1& getter1, const Getter2& g
RenderPrimitives3<RendererShaded>(getter1,getter2,color_getter);
} else {
const ImU32 col = ImGui::GetColorU32(s.Spec.FillColor);
GetterConstColor color_getter(col, s.Spec.FillAlpha);
GetterConstColor color_getter(col);
RenderPrimitives3<RendererShaded>(getter1,getter2,color_getter);
}
}
Expand Down