Sergey_Matyushenok_matyushenoksergei@yandex.by#25
Conversation
|
Your app does not work: |
HenadziStantchik
changed the title
Sergey582
changed the title
Sergey582
force-pushed
the
sergey_matyushenok
branch
from
b0aea9e to
285a90f
Compare
|
I did not discover any issues with your app work. |
HenadziStantchik
changed the title
Sergey582
changed the title
HenadziStantchik
changed the title
Sergey582
changed the title
|
Sometimes there is an empty line in
|
HenadziStantchik
changed the title
| To use caching you must have a postgresql database on your computer or laptop | ||
| with default parameters: | ||
| database="postgres", | ||
| user="postgres", | ||
| password="1", | ||
| host="localhost", | ||
| port="5432" | ||
| If you do not, follow these commands: | ||
| 1)Open terminal | ||
| 2)sudo apt-get install postgresql | ||
| 3)sudo -u postgres psql | ||
| 4)\password | ||
| 5)1 | ||
| 6)1 | ||
| 7)\conninfo find out the port and if it is not equal 5432, change the config.txt port to your |
There was a problem hiding this comment.
As you can see from our struggle, making your standard user to perform some additional steps like setting up the database / changing some parameters by his own hands is a bad idea for a project distribution.
In the real production all these steps are usually performed by bash scripts or inside docker containers so the user only need to write 1-2 lines in the terminal to get the things going.
It is ok to use postgres db if you are aiming for iteration 6, but ideally the process should be fully automated, so the user do not need to install/change any additional stuff
Sergey582
changed the title
HenadziStantchik
changed the title
|
I did not discover any issues with iteration 3 work |
Sergey582
changed the title
|
Сould you please tell me if saving to a file works for you? |
|
I did not discover any issues with Iteration 5 work. As for Iteration 4, looks good, but there is slight bug: if there is no path separator at the end of the path to the folder specified by user, files are saved in slightly wrong location: Both for html and pdf. Aside from that i did not discover any issues with Iteration 4, but be sure to test it thoroughly yourself in case I missed something. |
HenadziStantchik
changed the title
| database postgres | ||
| user postgres | ||
| password 1 | ||
| host localhost | ||
| port 5432 No newline at end of file |
There was a problem hiding this comment.
If you switched database, it is logical to remove this file.
|
Here is feedback on your application work: Tests are decently written, coverage percentage is high enough. |
3 participants
No description provided.