Roman_Shagun_rshag17@gmail.com by mdalag · Pull Request #24 · epam-python-courses-7-bsu/FinalTaskRssParser

mdalag · 2019-11-16T15:11:54Z

No description provided.

Add exceptions.py for custom exceptions Add logger.py for convenient output managment Add rss_feed.py to represent whole rss rss feed Add rss_item.py to store a single news item Implement rss_reader.py Add non-standart libs in requirements.txt

- Add tests for RssFeed and RssItem classes. - Refactor rss_reader.init_feed(): add new func to init list of news_items separately - Change RssFeed.print_feed() to be more convenient for usage and testing - Add README

HenadziStantchik · 2019-11-17T00:15:47Z

If the --limit is not specified, user should get all available feed. The same if the limit is too large.

- Implement setup.py - Add installation guide to README - Refactor code to log without custom logger - Fix PEP8 issues in rss_feed.py - Refactor rss_item.py to decode symbols via html lib - Remove standart libs fom requirements.txt - Fix var name issues in rss_feed.py

HenadziStantchik · 2019-11-18T13:59:50Z

Your app does not work if user tries to run it without using setuptools. (ModuleNotFoundError)

- Fix function names - Fix global variables names - Use slices in rss_reader.init_news_list - Implement manual adding of packages in setup.py - Change project structure to fix import errors - Change README - Add test for rss_reader.py - Add test test_feed.xml as test feed

HenadziStantchik · 2019-11-20T12:47:04Z

Here is some feedback on your app work:

Your app does not print DESCRIPTION field of news entry. (check the example in FinalTAsk.md)

Keep in mind that it should not have encoding problems too.

--date does not work together with --json

- Fix multiple exit points - Add DESCRIPTION - Fix --date now working with --json - Refactor rss_reader to be more clear - Add converters to .pdf and .html

dzhigailo · 2019-11-23T14:06:47Z

@@ -0,0 +1 @@
+!coverage.py: This is a private format, don't read it directly!{"lines":{"/home/mdalag/Documents/epam_task/FinalTaskRssParser/final_task/rss_reader/converters.py":[1,2,3,5,6,7,8,10,12,13,15,19,20,21,22,23,24,25,26,27,28,29,30,31,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,76,78,87,88,89,90,91,92,93,96,158],"/home/mdalag/Documents/epam_task/FinalTaskRssParser/final_task/rss_reader/exceptions_.py":[1,4,5,8,9,12,13],"/home/mdalag/Documents/epam_task/FinalTaskRssParser/final_task/rss_reader/rss_feed.py":[1,2,3,4,5,6,7,8,10,11,13,14,17,18,19,20,21,22,23,24,25,26,27,28,29,31,32,33,34,35,36,37,38,45,46,47,49,50,52,53,54,55,56,61,62,63,64,65,67,68,69,70,71,72,73,74,75,76,77,78,79],"/home/mdalag/Documents/epam_task/FinalTaskRssParser/final_task/rss_reader/rss_reader.py":[1,2,3,4,5,6,7,8,9,10,11,13,14,15,16,19,22,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,120,132,141,157,159,168,183,199,201,206],"/home/mdalag/Documents/epam_task/FinalTaskRssParser/final_task/rss_reader/rss_item.py":[1,2,3,4,5,8,17,18,19,20,21,22,23,24,25,27,28,29,30,32,33,34,35,36,37,38,39,40,41,42,43,44,45,47,48,50,51,52,53,54,56,57,59,60,62,63],"/home/mdalag/Documents/epam_task/FinalTaskRssParser/final_task/__init__.py":[1],"/home/mdalag/Documents/epam_task/FinalTaskRssParser/final_task/rss_reader/__init__.py":[1]}}


Please, add this file and file below to .gitignore

dzhigailo · 2019-11-23T14:07:32Z

@@ -0,0 +1 @@
+!coverage.py: This is a private format, don't read it directly!{"lines":{"/usr/local/lib/python3.7/dist-packages/rss_reader-1.0-py3.7.egg/tests/test_rss_item.py":[1,2,3,4,6,7,10,12],"/home/mdalag/Documents/epam_task/FinalTaskRssParser/final_task/rss_reader/rss_item.py":[1,2,3,4,5,8,17,18,19,20,21,22,23,24,25,27,32,33,45,52,62],"/home/mdalag/.local/lib/python3.7/site-packages/jsonpickle/__init__.py":[55,56,58,59,60,63,64,65,66,67,68,70,73,76,77,78,79,80,81,84,85],"/home/mdalag/.local/lib/python3.7/site-packages/jsonpickle/backend.py":[1,129,3,132,133,6,135,268,269,270,16,17,146,19,274,277,21,24,25,28,30,31,32,36,167,39,169,42,44,45,46,175,47,48,49,51,59,198,200,77,205,99,101,230,102,103,106,107,112,113,116,249,122,125,126],"/home/mdalag/.local/lib/python3.7/site-packages/jsonpickle/compat.py":[1,2,3,4,33,6,7,8,10,11,13,14,15,16,17,18,19,20],"/usr/lib/python3/dist-packages/simplejson/__init__.py":[132,133,134,135,136,137,138,139,140,141,142,143,144,145,146,147,148,149,402,403,408,538,158,288,573,466,99,100,101,103,104,105,108,110,112,113,114,115,116,117,118,119,123,125],"/usr/lib/python3/dist-packages/simplejson/errors.py":[2,3,6,38,40,15,52,26],"/usr/lib/python3/dist-packages/simplejson/raw_json.py":[8,2,4,7],"/usr/lib/python3/dist-packages/simplejson/decoder.py":[2,3,4,5,6,7,8,137,10,11,12,13,139,140,16,143,144,272,20,22,24,25,29,30,31,33,36,37,38,41,43,44,300,47,304,49,50,51,348,349,350,351,352,353,354,355,356,357,358,359,360,361,363,236,376],"/usr/lib/python3/dist-packages/simplejson/compat.py":[32,2,3,4,34,20,21,22,25,27,28,29,30,31],"/usr/lib/python3/dist-packages/simplejson/scanner.py":[2,3,4,5,6,7,8,11,13,15,16,17,20,85],"/usr/lib/python3/dist-packages/simplejson/encoder.py":[2,3,4,5,7,8,9,10,11,12,137,138,15,139,17,18,147,20,21,22,275,24,25,26,27,28,29,30,406,32,34,36,38,427,428,429,430,431,304,432,433,434,435,436,437,438,439,65,395,397,229,230,231,232,233,234,107,235,109,236,237,238,239,240,241,242,243,245,246,248,250,252,254,383],"/home/mdalag/.local/lib/python3.7/site-packages/jsonpickle/pickler.py":[7,8,9,10,11,12,139,14,15,16,17,18,19,144,149,533,158,34,546,295,171,559,307,181,184,314,322,581,592,598,216,220,606,99,612,487,622,111,495,241,244],"/home/mdalag/.local/lib/python3.7/site-packages/jsonpickle/util.py":[257,387,517,137,10,11,12,13,14,15,16,17,18,147,20,21,22,23,276,25,535,28,29,156,287,32,165,174,46,49,179,307,440,188,323,327,455,456,202,459,333,340,471,526,220,479,97,231,369,114,498,499,500,503,377,510,127],"/home/mdalag/.local/lib/python3.7/site-packages/jsonpickle/tags.py":[8,9,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51],"/home/mdalag/.local/lib/python3.7/site-packages/jsonpickle/handlers.py":[129,9,10,11,12,13,14,140,16,17,144,141,20,22,23,24,152,26,153,164,44,174,175,176,179,180,182,186,61,190,193,66,71,72,199,200,203,76,207,82,83,84,85,210,211,88,213,90,216,220,226,227,100,229,233,109,237,121],"/home/mdalag/.local/lib/python3.7/site-packages/jsonpickle/unpickler.py":[134,7,8,9,392,11,12,13,14,15,16,522,20,661,664,155,667,285,541,292,550,167,295,678,44,173,301,308,53,439,696,574,325,328,456,586,80,81,209,336,84,212,598,87,216,91,92,219,222,96,100,484,104,108,110,498,117,501,504,635],"/home/mdalag/.local/lib/python3.7/site-packages/jsonpickle/version.py":[1]}}


All .coverage related files should be added to .gitignore

dzhigailo · 2019-11-23T14:09:40Z

+        path += '/feed-' + str(datetime.datetime.now()) + get_extention(mode)
+    try:
+        LOGGER.debug('TRYING TO CREATE FILE...')
+        export_file = open(path, 'w', encoding='utf-8')


'w' flag in open function will always create new file if one not exists or overwrite existing file. If you want to check if path is valid, you could use tools from os lib
Also, please always use context manager while working with files.

HenadziStantchik · 2019-11-23T14:10:11Z

Please ensure that you have no encoding problems in converted html file.

Aside from this, i did not discover any issues with Iteration 4 work

dzhigailo · 2019-11-23T14:12:02Z

+        pdf.set_x(4)
+        pdf.cell(20, 6, 'Description:', ln=1)
+        pdf.set_x(20)
+        if len(news_item['description']) == 0:


if not news_item['description']:

- Fix indicated errors - Use pkg_resources for dynamic font detection - Change .pdf font to handle more symbols - Add font to MANIFEST.in - Fix unescaped characters in json and html - Change README.md setup section - Add tests for rss_reader

HenadziStantchik · 2019-11-24T23:09:29Z

I did not discover any issues with Iteration 4 functionality, but be sure to test it thoroughly in case I missed something

- Add colored output for news feed via colorama

- Convertion now works on Windows

HenadziStantchik · 2019-12-03T14:31:48Z

+    usage: rss_reader.py [-h] [--version] [--json] [--verbose] [--limit LIMIT] [--date DATE] [source]
+
+    RRS feed receiver
+
+    positional arguments:
+    source            URL for RSS feed
+
+    optional arguments:
+    -h, --help         show this help message and exit
+    --version          prints version
+    --json             converts news to JSON
+    --verbose          output verbose status messages
+    --limit LIMIT      determines the number of showed news.
+    --date DATE        shows cached news at given date
+    --to_pdf TO_PDF    coverts news to PDF.
+    --to_html TO_HTML  coverts news to HTML.
+
+    TO_PDF/TO_HTML - path to directory for file
+    File's name is in format feed-*current datetime*.*extention*


It seems you forgot to add --colorize here.

HenadziStantchik · 2019-12-03T14:32:27Z

+    return temp_img
+
+
+def get_pdf_doc(news_list):


This function is too large, it is better to try to split it.

HenadziStantchik · 2019-12-03T14:33:53Z

@@ -0,0 +1,3 @@
+Some shit happend :c with imports and I was had to run tests from /FinalTaskRssParser dir like this


Please do not use such language on work in any form.

HenadziStantchik · 2019-12-03T15:00:10Z

Here is feedback on your application:
Iteration 1:
Everything works fine.
Iteration 2:
Installs fine, all iterations work.
Iteration 3:
--date should be specified in YYYYMMDD format, not YYYYMMD:

Iteration 4:
Everything works fine.
Iteration 5:
--colorize must be just an option.

Tests are low in number, but the coverage percentage is enough. Still this is not a really good thing.
Code is mostly readable, absolutely corresponds to the PEP8 guidelines.
Commit messages are very informative and absolutely correspond to the recommended commit message style.

mdalag added 2 commits November 13, 2019 22:51

First iteration without tests

2f17153

Add exceptions.py for custom exceptions Add logger.py for convenient output managment Add rss_feed.py to represent whole rss rss feed Add rss_item.py to store a single news item Implement rss_reader.py Add non-standart libs in requirements.txt

Iteration 1 complete

1223adb

- Add tests for RssFeed and RssItem classes. - Refactor rss_reader.init_feed(): add new func to init list of news_items separately - Change RssFeed.print_feed() to be more convenient for usage and testing - Add README

HenadziStantchik reviewed Nov 17, 2019

View reviewed changes

Comment thread final_task/rss_reader/classes/logger.py Outdated

HenadziStantchik reviewed Nov 17, 2019

View reviewed changes

Comment thread final_task/rss_reader/classes/rss_item.py Outdated

HenadziStantchik reviewed Nov 17, 2019

View reviewed changes

Comment thread final_task/rss_reader/rss_reader.py Outdated

HenadziStantchik reviewed Nov 17, 2019

View reviewed changes

Comment thread final_task/rss_reader/classes/rss_feed.py Outdated

HenadziStantchik reviewed Nov 17, 2019

View reviewed changes

Comment thread final_task/rss_reader/requirements.txt Outdated

HenadziStantchik changed the title ~~Roman_Shagun_rshag17@gmail.com - PLEASE REVIEW~~ Roman_Shagun_rshag17@gmail.com Nov 17, 2019

mdalag changed the title ~~Roman_Shagun_rshag17@gmail.com~~ Roman_Shagun_rshag17@gmail.com - PLEASE REVIEW Nov 17, 2019

HenadziStantchik reviewed Nov 18, 2019

View reviewed changes

Comment thread final_task/rss_reader/classes/exceptions.py Outdated

HenadziStantchik reviewed Nov 18, 2019

View reviewed changes

Comment thread final_task/rss_reader/classes/rss_feed.py Outdated

HenadziStantchik reviewed Nov 18, 2019

View reviewed changes

Comment thread final_task/rss_reader/rss_reader.py Outdated

HenadziStantchik reviewed Nov 18, 2019

View reviewed changes

Comment thread final_task/rss_reader/rss_reader.py Outdated

HenadziStantchik reviewed Nov 18, 2019

View reviewed changes

Comment thread final_task/setup.py Outdated

HenadziStantchik changed the title ~~Roman_Shagun_rshag17@gmail.com - PLEASE REVIEW~~ Roman_Shagun_rshag17@gmail.com Nov 18, 2019

mdalag changed the title ~~Roman_Shagun_rshag17@gmail.com~~ Roman_Shagun_rshag17@gmail.com - PLEASE REVIEW Nov 20, 2019

HenadziStantchik reviewed Nov 20, 2019

View reviewed changes

Comment thread final_task/rss_reader/rss_item.py

HenadziStantchik reviewed Nov 20, 2019

View reviewed changes

Comment thread final_task/rss_reader/rss_item.py Outdated

HenadziStantchik reviewed Nov 20, 2019

View reviewed changes

Comment thread final_task/rss_reader/rss_reader.py Outdated

HenadziStantchik changed the title ~~Roman_Shagun_rshag17@gmail.com - PLEASE REVIEW~~ Roman_Shagun_rshag17@gmail.com Nov 20, 2019

Iteration 4

0309bb3

- Fix multiple exit points - Add DESCRIPTION - Fix --date now working with --json - Refactor rss_reader to be more clear - Add converters to .pdf and .html

mdalag changed the title ~~Roman_Shagun_rshag17@gmail.com~~ Roman_Shagun_rshag17@gmail.com - PLEASE REVIEW Nov 22, 2019

HenadziStantchik reviewed Nov 23, 2019

View reviewed changes

Comment thread final_task/rss_reader/converters.py Outdated

HenadziStantchik reviewed Nov 23, 2019

View reviewed changes

Comment thread final_task/rss_reader/converters.py Outdated

HenadziStantchik reviewed Nov 23, 2019

View reviewed changes

Comment thread final_task/rss_reader/rss_reader.py Outdated

dzhigailo reviewed Nov 23, 2019

View reviewed changes

HenadziStantchik changed the title ~~Roman_Shagun_rshag17@gmail.com - PLEASE REVIEW~~ Roman_Shagun_rshag17@gmail.com Nov 23, 2019

dzhigailo reviewed Nov 23, 2019

View reviewed changes

Fix iteration 4

96adf39

- Fix indicated errors - Use pkg_resources for dynamic font detection - Change .pdf font to handle more symbols - Add font to MANIFEST.in - Fix unescaped characters in json and html - Change README.md setup section - Add tests for rss_reader

mdalag changed the title ~~Roman_Shagun_rshag17@gmail.com~~ Roman_Shagun_rshag17@gmail.com - PLEASE REVIEW Nov 24, 2019

HenadziStantchik changed the title ~~Roman_Shagun_rshag17@gmail.com - PLEASE REVIEW~~ Roman_Shagun_rshag17@gmail.com Nov 24, 2019

mdalag added 2 commits November 25, 2019 21:32

Iteration 5

b30270f

- Add colored output for news feed via colorama

Fix path to file in converters.py according to OS

c6a6782

- Convertion now works on Windows

dzhigailo added the CODE FREEZE label Nov 25, 2019

HenadziStantchik reviewed Dec 3, 2019

View reviewed changes

		@@ -0,0 +1 @@
		!coverage.py: This is a private format, don't read it directly!{"lines":{"/home/mdalag/Documents/epam_task/FinalTaskRssParser/final_task/rss_reader/converters.py":[1,2,3,5,6,7,8,10,12,13,15,19,20,21,22,23,24,25,26,27,28,29,30,31,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,76,78,87,88,89,90,91,92,93,96,158],"/home/mdalag/Documents/epam_task/FinalTaskRssParser/final_task/rss_reader/exceptions_.py":[1,4,5,8,9,12,13],"/home/mdalag/Documents/epam_task/FinalTaskRssParser/final_task/rss_reader/rss_feed.py":[1,2,3,4,5,6,7,8,10,11,13,14,17,18,19,20,21,22,23,24,25,26,27,28,29,31,32,33,34,35,36,37,38,45,46,47,49,50,52,53,54,55,56,61,62,63,64,65,67,68,69,70,71,72,73,74,75,76,77,78,79],"/home/mdalag/Documents/epam_task/FinalTaskRssParser/final_task/rss_reader/rss_reader.py":[1,2,3,4,5,6,7,8,9,10,11,13,14,15,16,19,22,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,120,132,141,157,159,168,183,199,201,206],"/home/mdalag/Documents/epam_task/FinalTaskRssParser/final_task/rss_reader/rss_item.py":[1,2,3,4,5,8,17,18,19,20,21,22,23,24,25,27,28,29,30,32,33,34,35,36,37,38,39,40,41,42,43,44,45,47,48,50,51,52,53,54,56,57,59,60,62,63],"/home/mdalag/Documents/epam_task/FinalTaskRssParser/final_task/__init__.py":[1],"/home/mdalag/Documents/epam_task/FinalTaskRssParser/final_task/rss_reader/__init__.py":[1]}} No newline at end of file

		@@ -0,0 +1,3 @@
		Some shit happend :c with imports and I was had to run tests from /FinalTaskRssParser dir like this

Conversation

mdalag commented Nov 16, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HenadziStantchik commented Nov 17, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HenadziStantchik commented Nov 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HenadziStantchik commented Nov 20, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dzhigailo Nov 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HenadziStantchik commented Nov 23, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HenadziStantchik commented Nov 24, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HenadziStantchik Dec 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HenadziStantchik commented Dec 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HenadziStantchik commented Nov 18, 2019 •

edited

Loading

dzhigailo Nov 23, 2019 •

edited

Loading

HenadziStantchik Dec 3, 2019 •

edited

Loading