Kirill_Stepanishin_kirill.stpn.by@gmail.com#23
Conversation
kirill-stp
changed the title
|
fixed some bugs, iteration 1 ready |
kirill-stp
changed the title
|
Please fix your commit messages. We specifically stated in the FinalTask.md that commit messages should not look like that. |
|
I did not discover any issues with Iteration 1 functionality. Resolve commented issues and proceed to Iteration 2 |
HenadziStantchik
changed the title
…es in iteration 1
kirill-stp
changed the title
|
3rd iteration does not work (Ubuntu OS):
|
|
Also |
|
Please write a documentation to your app in |
HenadziStantchik
changed the title
| @@ -0,0 +1,87 @@ | |||
| from string_operations import * | |||
There was a problem hiding this comment.
It is better to not use wildcard import at all.
| description_ = extract_image_info_from_summary(parsed.summary) | ||
| self.media_description = make_string_readable(description_) | ||
|
|
||
| def print_readable_article(self, is_colored): |
There was a problem hiding this comment.
This function is large which lowers readability. It is better to split it somehow into the smaller ones.
| @@ -0,0 +1,203 @@ | |||
| import logging | |||
| import requests as r | |||
There was a problem hiding this comment.
It is better to avoid one-letter variable names. (This is a variable too)
| <<<<<<< HEAD | ||
| install_requires=['feedparser','requests','dominate','fpdf','termcolor'] | ||
| ======= | ||
| install_requires=['feedparser','requests','dominate','fpdf'] | ||
| >>>>>>> ee7ddc5f3897764b3da12847a678a2487a76a762 |
There was a problem hiding this comment.
There is unresolved conflict here
|
Here is feedback on your application: Tests are almost nonexistent. Coverage percentage is not enough. |
3 participants
iteration 1 without tests