Yuliya_Brechka_juliabrechka@gmail.com

[brechka]

Iteration 1 + Iteration 2

[HenadziStantchik]

.tar.gz file should not be checked in to GIT

[HenadziStantchik]

I am getting ImportError while trying to launch your script without using setup tools. Did you test it?

[HenadziStantchik]

Here is some feedback on your app work:

1. Links to images are sometimes missing:

2. Please add a documentation for your app

3. When trying to get app version:

4. Please fill your requirements.txt file

[dzhigailo]

There is a method .raise_for_status() in response object. You could is it

[brechka]

why this option is not suitable?

[HenadziStantchik]

This will not work correctly on Windows as it has different path separators

[HenadziStantchik]

Here is some feedback on your app:
Iteration 1:
Everything works fine.
Iteration 2:
Installs fine, but the installed app does not work. (Tried both on my machine and on clean machine)
Iteration 3:
Everything works fine. Good job implementing search by rss source.
Iteration 4:
Pdf conversion does not work:

HTML-converted file does not contain images. Also for some reason news feed is printed to stdout too when converting to HTML.

Iteration 5:
Colorizing works fine.

There are some redundant files checked in to repository.
__init__.py usually should be added to the tests folder so that you can run tests using python -m unittest discover.

Documentation is decently written.
Tests are ok, coverage percentage is sufficient.
The code itself is readable, well structured and absolutely corresponds to the PEP8 guiedelines.
Almost every method has docstring which is a plus.