Usevalad_Trafimau_Unioltered@gmail.com#18
Conversation
| @@ -0,0 +1,2 @@ | |||
| *.рус | |||
There was a problem hiding this comment.
You dont need to specify .gitignore in each folder. You can define it on project root. Please, add .idea to .gitignore
There was a problem hiding this comment.
.idea folder is not added still
|
Please add all files that are in |
Useftro
changed the title
| except ConnectionError: | ||
| logging.critical("CONNECTION ERROR, HELP!") | ||
| print("You have some connection problems!") | ||
| if '--date' in self.list_of_args: |
There was a problem hiding this comment.
You have done the same check in try block. Please, refactor this logic
|
Your project structure does not correspond to project structure specified in README.md |
|
Your |
|
Here is some feedback on your application work:
Same for
|
HenadziStantchik
changed the title
…stead of json to store news at local storage. Fixed some remarks.
Useftro
changed the title
|
Please make your project structure correspond to the one specified in README.md |
|
Your app does not work:
|
Useftro
changed the title
| logging.info("Trying to get page from feedparser!") | ||
| the_feed = feedparser.parse(self.feed_url) | ||
| logging.info("Got it (the page)!") | ||
| if the_feed.get('bozo') == 1: |
There was a problem hiding this comment.
You can use simple if the_feed.get('bozo'), because it can be either 1 or 0
| novelty = "\n{0}.\nTitle: {1}\nDate: {2}\nLink: {3}\nDescription:\n {4}\nImages links:{5}\nAlternative text:{6}\n" \ | ||
| "Main source: {7}" \ | ||
| .format(item.number_of_novelty, | ||
| pprint.pformat(item.title_of_novelty, width=115), | ||
| item.time_of_novelty, | ||
| pprint.pformat(item.source_link, width=115), | ||
| pprint.pformat(item.description.replace("\xa0", " "), width=115), | ||
| pprint.pformat(item.images_links), | ||
| pprint.pformat(item.alt_text, width=115), | ||
| item.main_source) |
There was a problem hiding this comment.
It is better to use formatted string for this: f"..."
|
Please remove cache and log files from this PR You can avoid such situations by simply adding each file individually before commit |
|
Please add new libraries to your |
|
If Also, I could not test your Iteration 4 work, because either it does not work or I installed wrong |
HenadziStantchik
changed the title
| * If '--colorize' is in console args then we colorize our news in random colors. If there is no '--colorize' | ||
| we use usual color (grey-white) | ||
| ## Important! | ||
| When using pdf or html converting input your path in look like this: "C:\\Test\\" or "C:\\Test" |
There was a problem hiding this comment.
What about Linux OS?
| 2. Add them into PDF or/and html file | ||
| 3. Add all other information | ||
|
|
||
| * If there is also '--date Y%M%D' in console with '--to-pdf' or/and '--to-html' we write down into the |
There was a problem hiding this comment.
It would be nice to have some info about how to install your app, and also more info about the way you store news entries locally.
|
Here is feedback on your application work: Some of the tests do not work: |
Empty link appears if there is not image in a piece of news. I thought it would be understandable if there is no link then it means that there is no image, but I understand my mistake that it's not understandable and I needed to write also "there is no image". Converting to HTML or PDF doesn't work not because of empty link because on my computer everything works fine with empty link. I have no idea why it doesnt' work. If --version and --json are specified program shows version of program and shows json view of news. |
This is a problem with our task, yes. I got your point. We will be sure to fix it in the future. |
3 participants
Please review
Iteration 1 completed (I hope so)