Elizaveta_Lapunova_liza.lapunova99@gmail.com

[ElizabethUniverse]

No description provided.

[ElizabethUniverse]

Thank you!

[HenadziStantchik]

tar.gz files should not be checked in to GIT

[HenadziStantchik]

If the RSS url is not specified, user would not be able to check app version. It should still work like this:
python rss_reader.py --version

Apart from that and some commented issues I did not discover any problems with app functionality

[HenadziStantchik]

Your app throws ModuleNotFound error if user tries to launch it without using setuptools.

Keep in mind that your app should work both with setuptools and without,

[HenadziStantchik]

Here is some feedback on your work:

1. PDF conversion does not work:

Keep in mind that user should specify directory for a converted file.
Also check your raise clauses (second traceback)

Same for html conversion.

Also ensure that encoding in the converted files is ok.

[HenadziStantchik]

Pdf conversion still does not work:

Please keep in mind that converted files should contain images:

the final text result should contain pictures and links, if they exist in the original article and if the format permits to store this type of data

[HenadziStantchik]

It should be 3.8

[HenadziStantchik]

This package name is incorrect

[HenadziStantchik]

Here is feedback on your application:
Iteration 1:
--json does not work for Cyrillic symbols.
Iteration 2:
Installs, but does not work.

Iteration 3:
Everything works fine.
Iteration 4:
PDF conversion does not work if there are news containing Cyrillic letters

Tests are decent, coverage percentage is high enough.
The code is mostly readable, decently structured, mostly corresponds to the PEP8 guidelines.
Commit messages do not correspond to the recommended commit message style.
Using templates for Iteration 4 is a plus.