Vitali_Kozlou_h4j0rx@gmail.com by kaz1ou · Pull Request #13 · epam-python-courses-7-bsu/FinalTaskRssParser

kaz1ou · 2019-11-08T13:08:31Z

Iterations 1 and 2 are done. Please review.

HenadziStantchik · 2019-11-08T13:16:58Z

+
+
+parser = argparse.ArgumentParser()
+parser.add_argument('--url', type=str, help='Please enter a valid URL for RSS Feed')


RSS url is supposed to be passed to your application without option --url check example in FinalTask.md

HenadziStantchik · 2019-11-08T13:20:27Z

+    :param verbose: True of False
+    :return: non-formatted feed
+    """
+    if verbose:


Here and below. For such logging purposes it is bettert to use logging standart library. Check it out

HenadziStantchik · 2019-11-08T13:34:01Z

Some feedback on your application work:

If user did not specify limit then he will only get 1 news entry. He/she should get all available feed instead
If the limit is larger than number of feed entries then you get the IndexError with traceback in stdout.
There are no --json argument (check iteration 1)
--verbose option should not get any arguments. For example:
python rss_reader.py <rss_url> --verbose]
UPD: the same for --version
Please add logging to more functions.

6 (optional). A minor thing but if there are many news printed it becomes hard to tell where ends one and starts another. Please separate them a bit better.

HenadziStantchik · 2019-11-09T16:52:41Z

Fixed all, according to your comments. Please review

Please do not use such commit messages. They should correspond to commit message style guide.
You can find it in materials section of our GIT session presentation

HenadziStantchik · 2019-11-09T17:14:11Z

+        print('Wait a second, we will check if there is any RSS in URL you have given')
+        print('-' * 50)
+    response = get(url)
+    r = response.headers['Content-Type']  # We will check only headers


It is better to avoid one-letter variable names

HenadziStantchik · 2019-11-09T17:15:20Z

If --version argument is specified application should just print its current bersion and shutdown.
Also user should be able to use --version argument without specifying source url.
Add a bit more logging to make ``-verbose` argument more explicit. For example, you can add some logging to functions that print news.
Right now your application just throws off images from the feed. for the future iterations you may want to have links to them (checkout example in FinalTask.md)
There is much redundant information in resulting json after using --json option.
There is also html and encoding problems in it.

Iterations 1 and 2 are ready.

8d1bcec