fix(tooling): make just typecheck check each workspace#33
Closed
eouzoe wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修改了什麼
Justfile的typecheckrecipe 從tsc --noEmit(根目錄)改為逐 workspace 檢查:apps/backend、apps/frontend、packages/shared。為什麼要修改
專案根目錄沒有
tsconfig.json,原本的tsc --noEmit在根目錄跑會報錯或跳過實際程式碼,型別檢查實質失效。功能
tsc --noEmit -p <dir>,任一失敗即exit 1。涉及檔案
Justfile(typecheck recipe,2 行變更)影響
tsc --noEmit -p apps/backend驗證 backend 可通過。參考文件 / 依據
apps/backend、apps/frontend、packages/shared各含獨立tsconfig.json。測試
tsc --noEmit -p .通過。