Add DRU routes - #165
Open
Florian-Katerndahl wants to merge 11 commits into
Open
Conversation
added 5 commits
July 16, 2026 17:05
As of now, the service implementing a given interface is loaded lazily upon the first request. However, when keeping changes to existing code-base minimal and loading DRU routes only when the actual service is loaded, DRU routes become addressable only after contacting an endpoint that is already exposed by OGC API - Processes Part 1. Directly loading a service on startup remedies this undesirable behavior. This change allows for `main.py` and `routes.py` to be left unchanged.
…0344150900bc34265742b5)
- Define DRU routes based on the DRUService interface with corresponding response classes and documentation of additional responses (both successful and error cases) for fastapi, using a distinct fastapi router instance - Define custom response class is used to correctly set the content type field of the server response
Collaborator
|
Please see applicable #168 |
Collaborator
|
Why do you think that most of the PR checklist items are non-applicable? |
Collaborator
Author
|
Because the PR, apart form the injection, doesn't add code that I thought of being worth getting tested or that needed updates to the documentation. Of course, this can be changed again, if wanted. |
forman
requested changes
Jul 27, 2026
forman
left a comment
forman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good!
But please stick to one notion; see also ApiError (in core models), not APIError.
ogcapppkg_response.py-->ap_response.py, and why a separate file at all?{processID}-->{processId}DRUService--> DruService`
Collaborator
Author
|
Addressed the comments, test cases are still not really possible since there's no implementation of a DRU compliant server in the eozilla repo. I'll also add other reviewer so this won't get blocked. |
Florian-Katerndahl
marked this pull request as ready for review
July 29, 2026 08:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load service implementation eagerly instead of lazily. Otherwise the DRU routes are added only after the request to an already endpoint. Additionally, the routes needed for DRU are added by using an additional fastAPI-router which is attached to an fastapi app instance.
Checklist (strike out non-applicable):
* [ ] Changes documented inCHANGES.md* [ ] Related issue exists and is referred to in the PR description andCHANGES.mddocs/** [ ] Unit-tests adapted/added for changes/features