api: add detectMisdirectedRequests to EnvoyProxy - #9675
Draft
mmmommm wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Kise Ryota <kiseryota.contact@gmail.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9675 +/- ##
==========================================
+ Coverage 75.34% 76.18% +0.83%
==========================================
Files 252 261 +9
Lines 41477 43528 +2051
==========================================
+ Hits 31252 33160 +1908
- Misses 8113 8165 +52
- Partials 2112 2203 +91 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zirain
reviewed
Aug 5, 2026
| // Default: false | ||
| // | ||
| // +optional | ||
| DetectMisdirectedRequests *bool `json:"detectMisdirectedRequests,omitempty"` |
Member
There was a problem hiding this comment.
can we have another top level fields for features like this may happen in the future?
Contributor
Author
There was a problem hiding this comment.
Sounds good. How about a typed struct named features like following?
spec:
features:
detectMisdirectedRequests: true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is part 1 of 3 for #5879, adding API support for GEP-3567 misdirected request detection.
This PR adds the
detectMisdirectedRequestsfield toEnvoyProxyand updates the generated API artifacts.Follow-up PRs will add:
HTTPRouteHTTPSListenerDetectMisdirectedRequests.The field defaults to disabled, and this PR does not change runtime behavior. The implementation is intentionally left for a follow-up PR so this PR can focus on the API
shape: field name, type, placement, and documentation.
Which issue(s) this PR fixes:
Fixes #5879
PR Checklist
git commit -s). See DCO: Sign your work./api), the API was discussed and agreed before the implementation. The API change can be in a separate PR, or in the same PR, but the API must be agreed before implementation. N/A if this PR does not contain API changes.make generate gen-check,make lint, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, butgen-check,lint, and coverage MUST pass.)release-notes/current/<section>/<pr-number>-<slug>.md(seerelease-notes/current/README.mdfor sections and naming). N/A if this PR does not contain non-trivial changes.make gen-checkand committed the result if API/helm charts/modules changed.release-notes/current/breaking_changes/.