feat(translator): active healthcheck logs - #9651
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95849ddd4b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
3f56bd1 to
4dcd158
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9651 +/- ##
==========================================
- Coverage 76.18% 76.18% -0.01%
==========================================
Files 261 261
Lines 43528 43589 +61
==========================================
+ Hits 33162 33208 +46
- Misses 8165 8173 +8
- Partials 2201 2208 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Guy Daich <guy.daich@sap.com> (cherry picked from commit d194472c8993afc9b87b9359f7b89aca0246f477) Signed-off-by: Guy Daich <guy.daich@sap.com>
|
/retest |
API
Adds support for configuring Envoy health check event logging via the
EnvoyProxyAPI as well asBTP/ClusterSettingsHC. Health check events (probe outcomes) can be written as JSON to a file sink (defaults to /dev/stdout).ProxyHealthCheckLogtype withmatches(event filter) andsinks(file sink)healthCheckLogfield added toProxyTelemetry(EnvoyProxy.spec.telemetry)healthCheckLogfield added toActiveHealthCheckfor per-backend configurationTranslation
EnvoyProxy:processHealthCheckLog()setsir.Xds.HealthCheckLogfrom EnvoyProxy.spec.telemetryBTP/ClusterSettings:ActiveHealthCheck.healthCheckLogin BTP/EEP/SecurityPolicy backendSettingsbuildHealthCheck()setsir.ActiveHealthCheck.BackendHealthCheckLogCloses #8753, #9381
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
PR Checklist
git commit -s). See DCO: Sign your work./api), the API was discussed and agreed before the implementation. The API change can be in a separate PR, or in the same PR, but the API must be agreed before implementation. N/A if this PR does not contain API changes.make generate gen-check,make lint, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, butgen-check,lint, and coverage MUST pass.)release-notes/current/<section>/<pr-number>-<slug>.md(seerelease-notes/current/README.mdfor sections and naming). N/A if this PR does not contain non-trivial changes.make gen-checkand committed the result if API/helm charts/modules changed.release-notes/current/breaking_changes/.