feat(chart): Add TLS certificate expiration to the Envoy Global dashboard - #9615
feat(chart): Add TLS certificate expiration to the Envoy Global dashboard#9615FlorisFeddema wants to merge 2 commits into
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Floris Feddema <floris.feddema@infosupport.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da16759e06
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
can you fix DCO? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9615 +/- ##
==========================================
+ Coverage 75.75% 76.05% +0.30%
==========================================
Files 254 259 +5
Lines 42322 43275 +953
==========================================
+ Hits 32059 32914 +855
- Misses 8107 8172 +65
- Partials 2156 2189 +33 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Floris Feddema <floris.feddema@infosupport.com>
|
@zirain I have fixed the DCO :) |
3 participants
What this PR does / why we need it:
This PR adds a TLS certificate expiration plane to the Envoy Global grafana dashboard that is bundled in the addons helm chart. The default ingress-nginx dashboard had these insights and it was very usefull.
Which issue(s) this PR fixes:
Fixes #9589
PR Checklist
git commit -s). See DCO: Sign your work./api), the API was discussed and agreed before the implementation. The API change can be in a separate PR, or in the same PR, but the API must be agreed before implementation. N/A if this PR does not contain API changes.make generate gen-check,make lint, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, butgen-check,lint, and coverage MUST pass.)release-notes/current/<section>/<pr-number>-<slug>.md(seerelease-notes/current/README.mdfor sections and naming). N/A if this PR does not contain non-trivial changes.make gen-checkand committed the result if API/helm charts/modules changed.release-notes/current/breaking_changes/.