Skip to content

feat: mergeType in envoy extension policy #9047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kkk777-7 wants to merge 1 commit into from
Closed

feat: mergeType in envoy extension policy #9047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions api/v1alpha1/envoyextensionypolicy_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,16 @@ type EnvoyExtensionPolicy struct {
type EnvoyExtensionPolicySpec struct {
PolicyTargetReferences `json:",inline"`

// MergeType determines how this configuration is merged with existing EnvoyExtensionPolicy
// configurations targeting a parent resource. When set, this configuration will be merged
// into a parent EnvoyExtensionPolicy (i.e. the one targeting a Gateway or Listener).
// This field cannot be set when targeting a parent resource (Gateway).
// If unset, no merging occurs, and only the most specific configuration takes effect.
//
// +kubebuilder:validation:XValidation:rule="self != 'Replace'",message="Replace is not a valid MergeType for EnvoyExtensionPolicy"

@chatgpt-codex-connector chatgpt-codex-connector Bot May 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reject mergeType on Gateway-targeted policies

The spec comment added for MergeType says it "cannot be set when targeting a parent resource (Gateway)", but the only validation here is self != 'Replace', so Gateway-targeted EnvoyExtensionPolicy objects with mergeType: StrategicMerge/JSONMerge are still admitted. At runtime those policies are processed by processEnvoyExtensionPolicyForGateway without any MergeType guard (so merge intent is effectively ignored), which creates a silent misconfiguration path for users. Please add a CEL/runtime validation that forbids mergeType when any target ref resolves to kind: Gateway.

Useful? React with 👍 / 👎.

// +optional
MergeType *MergeType `json:"mergeType,omitempty"`

// Wasm is a list of Wasm extensions to be loaded by the Gateway.
// Order matters, as the extensions will be loaded in the order they are
// defined in this list.
Expand Down
5 changes: 5 additions & 0 deletions api/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions ...s/gateway-crds-helm/templates/generated/gateway.envoyproxy.io_envoyextensionpolicies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1659,6 +1659,17 @@ spec:
|| (self.type == 'ValueRef' && !has(self.inline) && has(self.valueRef))
maxItems: 16
type: array
mergeType:
description: |-
MergeType determines how this configuration is merged with existing EnvoyExtensionPolicy
configurations targeting a parent resource. When set, this configuration will be merged
into a parent EnvoyExtensionPolicy (i.e. the one targeting a Gateway or Listener).
This field cannot be set when targeting a parent resource (Gateway).
If unset, no merging occurs, and only the most specific configuration takes effect.
type: string
x-kubernetes-validations:
- message: Replace is not a valid MergeType for EnvoyExtensionPolicy
rule: self != 'Replace'
targetRef:
description: |-
TargetRef is the name of the resource this policy is being attached to.
Expand Down
11 changes: 11 additions & 0 deletions ...gateway-helm/charts/crds/crds/generated/gateway.envoyproxy.io_envoyextensionpolicies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1658,6 +1658,17 @@ spec:
|| (self.type == 'ValueRef' && !has(self.inline) && has(self.valueRef))
maxItems: 16
type: array
mergeType:
description: |-
MergeType determines how this configuration is merged with existing EnvoyExtensionPolicy
configurations targeting a parent resource. When set, this configuration will be merged
into a parent EnvoyExtensionPolicy (i.e. the one targeting a Gateway or Listener).
This field cannot be set when targeting a parent resource (Gateway).
If unset, no merging occurs, and only the most specific configuration takes effect.
type: string
x-kubernetes-validations:
- message: Replace is not a valid MergeType for EnvoyExtensionPolicy
rule: self != 'Replace'
targetRef:
description: |-
TargetRef is the name of the resource this policy is being attached to.
Expand Down
Loading
Loading