chore: add e2e for SDS Ref - #8983
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f37285dda4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8983 +/- ##
==========================================
- Coverage 76.26% 76.25% -0.01%
==========================================
Files 261 261
Lines 43677 43677
==========================================
- Hits 33309 33307 -2
- Misses 8165 8169 +4
+ Partials 2203 2201 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
e8cc5c6 to
1d9874f
Compare
|
Question: Why are SDS Secrets only supported for backend TLS? It seems reasonable to also support them for listener certificates, since Envoy can fetch listener certs via SDS. |
I found out this when debuging this, we could support it with a patch. |
| namespace: gateway-conformance-infra | ||
| type: gateway.envoyproxy.io/sds | ||
| data: | ||
| # base64(/var/run/sds/sds.sock) |
There was a problem hiding this comment.
can we make sure unix scheme is used here to allow uds, how do we deal with this in other places of the API surface
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions! |
|
rebase after #9525 merged. |
Signed-off-by: zirain <zirain2009@gmail.com>
4 participants
xref: #8839