api: split ClusterSettings into BackendSettings and ClusterSettings - #8899
Open
muwaqar-cflt wants to merge 5 commits into
Open
api: split ClusterSettings into BackendSettings and ClusterSettings#8899muwaqar-cflt wants to merge 5 commits into
muwaqar-cflt wants to merge 5 commits into
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d5671b0a1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Member
|
Hi @muwaqar-cflt, the new API shape looks good to me. Thanks for the quick PR! A couple of questions:
cc @envoyproxy/gateway-maintainers , please chime in. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8899 +/- ##
==========================================
+ Coverage 76.19% 76.20% +0.01%
==========================================
Files 261 261
Lines 43528 43528
==========================================
+ Hits 33164 33170 +6
+ Misses 8161 8158 -3
+ Partials 2203 2200 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zhaohuabing
reviewed
May 25, 2026
zhaohuabing
previously approved these changes
May 25, 2026
zhaohuabing
reviewed
May 25, 2026
zhaohuabing
self-requested a review
May 25, 2026 02:48
muwaqar-cflt
changed the title
muwaqar-cflt
force-pushed
the
backend-cluster-settings
branch
from
June 11, 2026 19:49
74b8411 to
5e69afc
Compare
muwaqar-cflt
force-pushed
the
backend-cluster-settings
branch
from
June 16, 2026 15:44
5e69afc to
159b4e2
Compare
muwaqar-cflt
changed the title
zhaohuabing
approved these changes
Jun 25, 2026
zhaohuabing
force-pushed
the
backend-cluster-settings
branch
from
June 25, 2026 13:48
a08ab35 to
9084c06
Compare
zhaohuabing
previously approved these changes
Jun 25, 2026
kkk777-7
previously approved these changes
Jul 22, 2026
Member
|
LGTM, thanks! |
…ields Extract CDS-only fields (LoadBalancer, ProxyProtocol, TCPKeepalive, HealthCheck, CircuitBreaker, Timeout, Connection, DNS, HTTP2) into BackendClusterSettings. ClusterSettings embeds it inline and adds Retry. JSON field paths are unchanged (non-breaking). Closes envoyproxy#8898 Signed-off-by: Muhammad Waqar <waqar.hameed08@gmail.com>
Address reviewer feedback to use a shorter, clearer name. Signed-off-by: Muhammad Waqar <waqar.hameed08@gmail.com>
… BackendSettings Swap type names per reviewer feedback: the CDS-only struct becomes ClusterSettings and the wrapper (with Retry) becomes BackendSettings. Also rename clustersettings.go to backendsettings.go. Signed-off-by: Muhammad Waqar <waqar.hameed08@gmail.com>
…s after rebase Rebasing onto main picked up test cases that construct BackendTrafficPolicySpec with a direct ClusterSettings field, which this branch's split moved one level deeper under the new BackendSettings field. git's auto-merge didn't flag these as conflicts since the surrounding lines didn't textually overlap. Signed-off-by: Muhammad Waqar <mwaqar@confluent.io>
The rebase's conflict resolution took a stale snapshot of this generated file; regenerate it properly from the current API types. Signed-off-by: Muhammad Waqar <mwaqar@confluent.io>
muwaqar-cflt
force-pushed
the
backend-cluster-settings
branch
from
August 5, 2026 15:21
9084c06 to
e3a3351
Compare
zhaohuabing
approved these changes
Aug 6, 2026
Member
|
LGTM. Deferring to @guydc I'm also OK with delaying this to EG API graduating to V1. |
zirain
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract CDS-only fields from the existing
ClusterSettingsinto a dedicatedClusterSettingsstruct, and rename the wrapper (which addsRetry) toBackendSettings.BackendSettingsembedsClusterSettingsinline and addsRetry. JSON field paths are unchanged — this is a non-breaking refactor.Closes #8898
Fields in
ClusterSettings(CDS-only)loadBalancerproxyProtocoltcpKeepalivehealthCheckcircuitBreakertimeoutconnectiondnshttp2Fields in
BackendSettings(wrapper)ClusterSettingsinlineretry(RDS concern, not applicable to Backend targets)Test plan
go build ./...succeedsmake lintpassesmake formatpassesmake gen-checkpasses