feat: allow to patch multiple resources with EPP by zirain · Pull Request #8518 · envoyproxy/gateway

zirain · 2026-03-13T06:41:52Z

netlify · 2026-03-13T06:41:58Z

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Name	Link
🔨 Latest commit	`2d67b64`
🔍 Latest deploy log	https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/6a709b04261cd7000870c081
😎 Deploy Preview	https://deploy-preview-8518--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

codecov · 2026-03-13T07:05:10Z

Codecov Report

❌ Patch coverage is 58.04598% with 73 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.00%. Comparing base (4898608) to head (2d67b64).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/gatewayapi/envoypatchpolicy.go	11.90%	34 Missing and 3 partials ⚠️
internal/xds/translator/jsonpatch.go	70.76%	15 Missing and 4 partials ⚠️
internal/xds/translator/translator.go	73.43%	9 Missing and 8 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8518      +/-   ##
==========================================
- Coverage   76.05%   76.00%   -0.06%     
==========================================
  Files         260      260              
  Lines       43367    43543     +176     
==========================================
+ Hits        32984    33093     +109     
- Misses       8184     8236      +52     
- Partials     2199     2214      +15

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jukie · 2026-04-01T04:36:42Z

+			// If there are multiple dests and some of them fail,
+			// consider it as successful and ignore the failures to patch other dests.
+			if !anyPatched && patchErrors != nil {
+				tErrs = errors.Join(tErrs, patchErrors)


Is there a better way to handle partial failures rather than marking as programmed and success? How does a user monitor and/or become aware of failures?

it's hard, you may want to add a http filter to all listener, but it will failed on tcp listeners which is valid.

arkodg · 2026-04-01T23:33:35Z

can we update the title to api instead of fix, since its changing the API

arkodg · 2026-04-26T03:27:59Z

+			status.SetAcceptedForPolicyAncestor(&policy.Status, &ancestorRef, t.GatewayControllerName, policy.Generation)
+		} else {
+			// Clear any partial patches that were added before validation failed
+			policyIR.JSONPatches = nil


this is changing the existing logic, curious why we are doing it in this PR

xref: #8518 (comment)

zirain · 2026-05-14T06:32:10Z

@codex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2ec8965a3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-14T06:36:01Z

+		if !ok {
+			continue
+		}
+		if stringMatched(name, listener.Name) {


Exclude the readiness listener from broad listener selectors

When a policy uses a broad listener selector such as the new e2e RegularExpression: .*, this loop also selects the generated readiness listener (envoy-gateway-proxy-ready-*) from the same resource table, not just the listeners for the targeted Gateway. Patches that are valid for Gateway HTTP listeners, for example /default_filter_chain/... in test/e2e/testdata/envoy-patch-policy.yaml, then fail against the readiness listener and mark the policy Programmed=False, or can unintentionally mutate readiness configuration.

Useful? React with 👍 / 👎.

this could be avoided by using corrected regex expression, @envoyproxy/gateway-maintainers should we leave this to users?

github-actions · 2026-06-13T09:01:50Z

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

arkodg · 2026-08-03T03:03:48Z

-// TODO: return multiple resources
-func findXdsResource(tCtx *types.ResourceVersionTable, p *ir.JSONPatchConfig) (cachetypes.Resource, error) {
+// findXdsResources returns XDS resources to patch based on the patch configuration.
+func findXdsResources(tCtx *types.ResourceVersionTable, p *ir.JSONPatchConfig) ([]cachetypes.Resource, error) {


do we have any data on perf hit because of using the new search which will now always go to the end of the list

could escape early for Exact match, for other match type we couldn't.

Signed-off-by: zirain <zirain2009@gmail.com>

zirain force-pushed the patch-multi-resources branch from ed6c528 to ded9e1e Compare March 13, 2026 06:43

zirain force-pushed the patch-multi-resources branch from ded9e1e to ec71f58 Compare March 23, 2026 06:37

zirain marked this pull request as ready for review March 23, 2026 10:56

zirain requested a review from a team as a code owner March 23, 2026 10:56

zirain force-pushed the patch-multi-resources branch 2 times, most recently from 71f5191 to 2b6f0f4 Compare March 25, 2026 10:55

zirain added this to the v1.8.0-rc.1 Release milestone Mar 30, 2026

jukie reviewed Apr 1, 2026

View reviewed changes

Comment thread internal/xds/translator/translator.go Outdated

jukie reviewed Apr 1, 2026

View reviewed changes

zirain force-pushed the patch-multi-resources branch 2 times, most recently from a30674c to 5a0b04d Compare April 1, 2026 08:10

zirain changed the title ~~fix: allow to patch multiple resources with EPP~~ api: allow to patch multiple resources with EPP Apr 1, 2026

zirain force-pushed the patch-multi-resources branch from d2f646a to 2d1bd50 Compare April 1, 2026 23:35

arkodg reviewed Apr 2, 2026

View reviewed changes

Comment thread api/v1alpha1/envoypatchpolicy_types.go Outdated

zirain force-pushed the patch-multi-resources branch 3 times, most recently from f638718 to 3a7991f Compare April 2, 2026 04:00

jukie reviewed Apr 3, 2026

View reviewed changes

Comment thread internal/xds/translator/translator.go

zirain requested review from arkodg and jukie April 4, 2026 00:39

arkodg reviewed Apr 6, 2026

View reviewed changes

Comment thread api/v1alpha1/envoypatchpolicy_types.go Outdated

zirain force-pushed the patch-multi-resources branch 3 times, most recently from 830fbd4 to 84692af Compare April 7, 2026 10:42

zirain requested a review from arkodg April 9, 2026 07:02

zirain changed the title ~~api: allow to patch multiple resources with EPP~~ feat: allow to patch multiple resources with EPP Apr 14, 2026

zirain force-pushed the patch-multi-resources branch from eb4b4b5 to 73a6372 Compare April 14, 2026 11:27

jukie requested a review from a team April 25, 2026 02:28

arkodg reviewed Apr 26, 2026

View reviewed changes

arkodg modified the milestones: v1.8.0-rc.1 Release, v1.9.0-rc.1 Release Apr 30, 2026

zirain force-pushed the patch-multi-resources branch 2 times, most recently from e721c79 to b2ec896 Compare May 14, 2026 04:48

chatgpt-codex-connector Bot reviewed May 14, 2026

View reviewed changes

zirain force-pushed the patch-multi-resources branch from 15d2562 to 723f64b Compare May 14, 2026 08:50

github-actions Bot added the stale label Jun 13, 2026

github-actions Bot closed this Jun 20, 2026

zirain reopened this Jun 20, 2026

github-actions Bot removed the stale label Jun 20, 2026

zirain force-pushed the patch-multi-resources branch from 723f64b to da6cc12 Compare June 26, 2026 02:39

zirain force-pushed the patch-multi-resources branch from da6cc12 to 025b3a3 Compare July 21, 2026 01:53

zirain force-pushed the patch-multi-resources branch from 025b3a3 to d59de64 Compare July 29, 2026 02:36

arkodg reviewed Aug 3, 2026

View reviewed changes

zirain added 5 commits August 3, 2026 11:34

fix: support patch multiple resources in EPP

662ce33

Signed-off-by: zirain <zirain2009@gmail.com>

fix

37813a6

Signed-off-by: zirain <zirain2009@gmail.com>

remove skip

3a49710

Signed-off-by: zirain <zirain2009@gmail.com>

fix

8d10c67

Signed-off-by: zirain <zirain2009@gmail.com>

release notes

18d9544

Signed-off-by: zirain <zirain2009@gmail.com>

zirain force-pushed the patch-multi-resources branch from d59de64 to 18d9544 Compare August 3, 2026 03:34

zirain added 3 commits August 3, 2026 15:50

fix gen

debda73

Signed-off-by: zirain <zirain2009@gmail.com>

Merge branch 'main' into patch-multi-resources

8870860

fix merge

a12a613

Signed-off-by: zirain <zirain2009@gmail.com>

zirain force-pushed the patch-multi-resources branch from 0b37770 to a12a613 Compare August 3, 2026 13:22

fix message

2d67b64

Signed-off-by: zirain <zirain2009@gmail.com>

zirain force-pushed the patch-multi-resources branch from 648f86b to 2d67b64 Compare August 3, 2026 13:43

Uh oh!

Conversation

zirain commented Mar 13, 2026

Uh oh!

netlify Bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Uh oh!

codecov Bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

jukie Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

zirain Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

arkodg commented Apr 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arkodg Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

zirain Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

zirain commented May 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 14, 2026

Choose a reason for hiding this comment

Uh oh!

zirain May 14, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 13, 2026

Uh oh!

arkodg Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

zirain Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify Bot commented Mar 13, 2026 •

edited

Loading

codecov Bot commented Mar 13, 2026 •

edited

Loading