Skip to content

Fix publish workflows breaking on the js-yaml control-panel import - #119

Merged
nateshpp merged 4 commits into
mainfrom
fix-publish-edge-deps
Jul 6, 2026
Merged

nateshpp merged 4 commits into
mainfrom
fix-publish-edge-deps

Conversation

@nateshpp

@nateshpp nateshpp commented Jul 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • publish-edge just failed on main after Add full CRUD for roles/models/providers/runners to the control panel #115 merged: npm publish's prepublishOnly script runs the full test suite, and two root tests (tests/control-panel-work-item-writer.test.mjs, tests/control-panel-writer-nested.test.mjs) import apps/control-panel/server/*.mjs directly, which needs js-yaml — a dependency that only lives in apps/control-panel/node_modules. Neither publish-edge.yml nor publish.yml installed it.
  • Fixes both workflows by installing design-system and apps/control-panel dependencies right after npm ci, before the publish step runs.
  • publish.yml's publish job has the same latent bug and would have hit it on the next stable v* tag push; fixed preemptively. Its gate job (npm run evidence) doesn't touch the test suite, so it wasn't affected.
  • Also re-ran the failed pages deploy job on the same commit — that failure was a separate, transient "Deployment failed, try again later." from GitHub's Pages API, unrelated to this bug.

Test plan

  • npm test — 790/790 passing (with control-panel deps installed, matching what the fixed workflow now does)
  • node scripts/guard-ratchet.mjs origin/main — clean
  • npm run check:drift, check:style, check-md-governance, check-self-application all pass
  • node scripts/hygiene.mjs check . — clean
  • Validated both workflow YAML files parse correctly

Both publish-edge.yml and publish.yml run npm publish, whose
prepublishOnly script runs the full test suite. Two root tests import
apps/control-panel/server/*.mjs directly, which needs js-yaml -- a
dependency that only lives in apps/control-panel/node_modules. This
just broke publish-edge on main; publish.yml has the same latent bug
and would hit it on the next stable tag push.
@nateshpp
nateshpp requested a review from techseek4vr as a code owner July 5, 2026 06:44
@nateshpp
nateshpp merged commit 9c8db7a into main Jul 6, 2026
5 checks passed
@nateshpp
nateshpp deleted the fix-publish-edge-deps branch July 6, 2026 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant