Repository navigation
Fix publish workflows breaking on the js-yaml control-panel import - #119
Merged
Merged
Conversation
Both publish-edge.yml and publish.yml run npm publish, whose prepublishOnly script runs the full test suite. Two root tests import apps/control-panel/server/*.mjs directly, which needs js-yaml -- a dependency that only lives in apps/control-panel/node_modules. This just broke publish-edge on main; publish.yml has the same latent bug and would hit it on the next stable tag push.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish-edgejust failed onmainafter Add full CRUD for roles/models/providers/runners to the control panel #115 merged:npm publish'sprepublishOnlyscript runs the full test suite, and two root tests (tests/control-panel-work-item-writer.test.mjs,tests/control-panel-writer-nested.test.mjs) importapps/control-panel/server/*.mjsdirectly, which needsjs-yaml— a dependency that only lives inapps/control-panel/node_modules. Neitherpublish-edge.ymlnorpublish.ymlinstalled it.design-systemandapps/control-paneldependencies right afternpm ci, before the publish step runs.publish.yml'spublishjob has the same latent bug and would have hit it on the next stablev*tag push; fixed preemptively. Itsgatejob (npm run evidence) doesn't touch the test suite, so it wasn't affected.pagesdeploy job on the same commit — that failure was a separate, transient "Deployment failed, try again later." from GitHub's Pages API, unrelated to this bug.Test plan
npm test— 790/790 passing (with control-panel deps installed, matching what the fixed workflow now does)node scripts/guard-ratchet.mjs origin/main— cleannpm run check:drift,check:style,check-md-governance,check-self-applicationall passnode scripts/hygiene.mjs check .— clean