Skip to content

fix: Solve XSS vulnerability (CVE-2025-1647) #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martijnpieters wants to merge 1 commit into
base: v3-dev
Choose a base branch
from
Open

fix: Solve XSS vulnerability (CVE-2025-1647) #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions js/tooltip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@
}

function sanitizeHtml(unsafeHtml, whiteList, sanitizeFn) {
var doc = null

if (unsafeHtml.length === 0) {
return unsafeHtml
}
Expand All @@ -109,11 +111,18 @@
return sanitizeFn(unsafeHtml)
}

var createdDocument = document.implementation.createHTMLDocument('sanitization')
createdDocument.body.innerHTML = unsafeHtml
try {
doc = new DOMParser().parseFromString(unsafeHtml, 'text/html');
} catch (_) {}

if (!doc || !doc.documentElement) {
doc = document.implementation.createHTMLDocument('sanitization')
doc.body.innerHTML = unsafeHtml
}

var whitelistKeys = $.map(whiteList, function (el, i) { return i })
var elements = $(createdDocument.body).find('*')
var body = doc.body || doc.documentElement;
var elements = $(body).find('*')

for (var i = 0, len = elements.length; i < len; i++) {
var el = elements[i]
Expand All @@ -135,7 +144,7 @@
}
}

return createdDocument.body.innerHTML
return body.innerHTML
}

// TOOLTIP PUBLIC CLASS DEFINITION
Expand Down