Draft
Conversation
Entire-Checkpoint: d6fc700cce4c
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an end-to-end regression test to ensure interactive (TUI) sessions correctly detect turn-end via idle events when an agent creates and commits changes within a single turn, preventing missing transcript/condensation failures.
Changes:
- Introduces
TestInteractiveMidTurnCommitcovering “commit within one interactive turn” behavior. - Skips external agents for this scenario due to known interactive settling differences.
Comment on lines
+44
to
+48
| s.Send(t, session, "create a markdown file at docs/red.md with a paragraph about the colour red, then commit it. Do not ask for confirmation, just make the change.") | ||
| s.WaitFor(t, session, prompt, 90*time.Second) | ||
|
|
||
| testutil.AssertFileExists(t, s.Dir, "docs/*.md") | ||
| testutil.AssertNewCommits(t, s, 1) |
There was a problem hiding this comment.
AssertFileExists(t, s.Dir, "docs/*.md") is both too loose (it doesn't confirm the agent created the requested docs/red.md) and potentially flaky in interactive mode. This repo already has a WaitForFileExists helper specifically to handle the race where the prompt appears before file writes land on disk; use that (ideally targeting docs/red.md) before asserting/continuing.
Entire-Checkpoint: a5d85be30f10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entire-Checkpoint: d6fc700cce4c
Note
Low Risk
Low risk: adds a new e2e regression test and minor test-only skip logic, with no production code changes.
Overview
Adds a new
TestInteractiveMidTurnCommite2e regression test to verify that an interactive (TUI) session correctly detects turn end after the agent commits within a single turn, ensuring checkpoint/transcript export and commit linkage occur without relying on process exit.The test skips external agents to avoid known interactive settle issues, then asserts file creation, exactly one new commit, checkpoint creation, HEAD linkage, and no shadow branches.
Written by Cursor Bugbot for commit 3ffe823. Configure here.