External Agent: Add Windows-compatible agent name derivation#729
Merged
nodo merged 3 commits intoentireio:mainfrom Mar 25, 2026
Merged
External Agent: Add Windows-compatible agent name derivation#729nodo merged 3 commits intoentireio:mainfrom
nodo merged 3 commits intoentireio:mainfrom
Conversation
keyu98
changed the title
Contributor
Author
Thanks for the review! I've simplified stripExeExt as suggested and added tests for it in the latest commit. |
nodo
reviewed
Mar 24, 2026
Contributor
nodo
left a comment
nodo
left a comment
There was a problem hiding this comment.
LGTM, please have a look at the failing test, then I am happy to approve.
keyu98
force-pushed
the
feature/windows-support-external-agent
branch
from
c5c78b8 to
fa77853
Compare
nodo
approved these changes
Mar 25, 2026
Contributor
|
Thank you @keyu98 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
External agent discovery currently fails to correctly derive agent names on Windows because:
.exe,.bat,.cmd) that get included in the agent name.mode & 0o111) rejects all binaries on Windows, since Windows doesn't set POSIX execute permission bits.Changes
stripExeExt()helper. This removes.exe,.bat, and.cmdsuffixes so thatentire-agent-foo.execorrectly resolves to agent namefoo. On Unix this is a no-op.runtime.GOOS != "windows"), since Windows filesystems do not expose POSIX permission bits.Files changed
cmd/entire/cli/agent/external/discovery.go