Skip to content
This repository was archived by the owner on Sep 21, 2019. It is now read-only.

Conversation

@nickdiego
Copy link

After f6abb66, classpath read from
bootstrap classpath file must be splitted into
a list before to be passed to _start_process.

Signed-off-by: Nick Diego Yamane nick.diego@gmail.com

After f6abb66, classpath read from
bootstrap classpath file must be splitted into
a list before to be passed to _start_process.

Signed-off-by: Nick Diego Yamane <nick.diego@gmail.com>
@nickdiego nickdiego changed the title Fix #393 Fix !393 Apr 19, 2017
@nickdiego nickdiego changed the title Fix !393 Fix #393 Apr 19, 2017
@ches
Copy link
Contributor

ches commented Apr 19, 2017

Hi Nick, thank you for identifying and fixing this.

All this stuff is getting pretty fiddly though especially since the Windows path fix changes, I didn't see those very closely when they were first added. Would you mind trying to add a test or two covering this? There are some existing tests for the launcher. I know that actually testing execution of the SbtBootstrap strategy would be painful, but since what's in question here happens prior to the execution I'm hoping we could get a few unit tests on it with some mocking that hopefully isn't too arduous.

@ches
Copy link
Contributor

ches commented Apr 19, 2017

Side note: we need to figure out why our CI build isn't working properly. There was some issue when Drone infrastructure was moved a few months back, I don't know that it got specifically resolved but now builds apparently run yet don't actually do anything… maybe it's a new version of Drone and we have an old config format, or something.

@nickdiego
Copy link
Author

Hi @ches, Thanks for the quick feedback.
Unfortunately I'm pretty busy with another activities and this quick fix was the best effor I could do to give a try on ensime with Android stuff. Maybe I could help with those tests soon, but now it's impossible for me :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants