Dev veri ac loss

[enjoyneer87]

This pull request introduces several significant updates and improvements across the codebase, focusing on new functionality, code maintenance, and bug fixes. The most notable changes include the addition of a versatile BasisModel class for fitting and evaluating various basis functions, enhancements to MotorCAD data processing and visualization, and cleanup of phasor diagram plotting logic.

New functionality and model fitting

• Added a comprehensive BasisModel class that supports fitting and evaluating multiple basis types (polynomial, RBF, Chebyshev, Legendre, thinplate, and tpaps), with methods for normalization, convex hull masking, degree selection, and table-based fitting. This greatly enhances the flexibility and reusability of basis function modeling in the codebase.

MotorCAD data processing and visualization

• Introduced devPlotMCADIronLossCoeffMap, a new function for visualizing and interpolating MotorCAD FEA loss coefficient data with improved mesh and spline interpolation, facilitating more accurate and higher-resolution analysis.
• Added comments and minor code improvements to MotorCAD-related scripts, including clearer variable loading and workspace setup. [1] [2] [3] [4] [5]

Phasor diagram plotting and cleanup

• Removed the obsolete and overly complex blondelPhasorDiagram function, streamlining the codebase and reducing maintenance burden.
• Simplified axis plotting in the phasor diagram logic by removing redundant quiver calls, improving clarity and maintainability.

Minor improvements and bug fixes

• Corrected a function name typo from plot_xdxq to plot_xdyq, ensuring proper function referencing and invocation.
• Updated JMAG version default from 210 to 222 in JmagData, ensuring compatibility with newer software releases.
• Fixed minor formatting and assignment issues in JMAG export logic and result plotting scripts. [1] [2]This pull request introduces several new features and improvements, primarily focused on modeling, visualization, and code maintenance for electric machine data analysis. The most significant change is the addition of a flexible and extensible basis function modeling class, which supports various basis types and fitting strategies. There are also enhancements to data visualization, including new plotting functions and updates to phasor diagram routines, as well as minor bug fixes and code cleanups.

Modeling and Fitting Enhancements

• Added new BasisModel class for flexible 2D surface fitting, supporting polynomial, RBF, Chebyshev, Legendre, thin-plate spline, and TPAPS basis functions, with normalization, convex hull masking, and automatic degree selection. (Class/BasisModel.m)

Visualization and Plotting Improvements

• Added new function devPlotMCADIronLossCoeffMap for visualizing MotorCAD FEA iron loss coefficient maps, including interpolation and mesh plotting of flux linkage surfaces. (Class/@MotorcadData/devPlotMCADIronLossCoeffMap.m)
• Updated phasor diagram routines by removing redundant axis quiver calls for cleaner plots. (Class/Jmag/@JmagData/phasor_diagram.m)
• Minor bug fix to ensure proper CSV file naming in JMAG graph export. (Class/Jmag/@JmagData/jmagFcnGraphExport.m)
• Updated function name for plotting dq maps from plot_xdxq to plot_xdyq for clarity and consistency. (Class/@DataDqMap/plot_xdyq.m)

Maintenance and Miscellaneous

• Updated default JMAG version from '210' to '222' for compatibility with newer software. (Class/Jmag/@JmagData/JmagData.m)
• Removed obsolete or redundant code, such as the entire blondelPhasorDiagram function. (Class/blondelPhasorDiagram.m)
• Added reference to default MotorCAD settings for improved documentation. (Class/Motorcad/fcnACLoss.m)

Minor Fixes and Comments

• Added comments and minor code cleanups in data export and post-processing functions for MotorCAD. (Class/@MotorcadData/exportRawLossMap.m, Class/@MotorcadData/rawPsiDataPost.m) [1] [2] [3] [4]
• Commented out unnecessary MotorCAD server instantiation in result phasor diagram function. (Class/motorcadResultPhasorDiagram.m)This pull request introduces several updates and new features across the codebase, with a focus on new modeling capabilities, bug fixes, and improvements to phasor diagram plotting and MotorCAD/JMAG integrations. The most significant change is the addition of the new BasisModel class, which provides flexible 2D surface fitting using various basis functions. There are also improvements to MotorCAD/JMAG version handling, plotting routines, and code clarity.

New Feature: Basis Modeling

• Added a comprehensive new class BasisModel for fitting and evaluating 2D surfaces using polynomial, RBF, Chebyshev, Legendre, thin-plate spline, and TPAPS basis functions, including normalization, convex hull masking, and automatic degree selection. (Class/BasisModel.m)

MotorCAD/JMAG Integration Improvements

• Updated default JMAG version from '210' to '222' in JmagData to ensure compatibility with newer JMAG releases. (Class/Jmag/@JmagData/JmagData.m)
• Improved file path and result CSV naming conventions for JMAG graph export, and clarified variable assignments. (Class/Jmag/@JmagData/jmagFcnGraphExport.m)
• Added comments and improved clarity in MotorCAD loss export and AC loss functions. (Class/@MotorcadData/exportRawLossMap.m, Class/Motorcad/fcnACLoss.m) [1] [2]

Plotting and Visualization Updates

• Fixed function name typo in plot_xdyq and improved phasor diagram axis plotting for better visualization. (Class/@DataDqMap/plot_xdyq.m, Class/Jmag/@JmagData/phasor_diagram.m) [1] [2]
• Removed obsolete and redundant code from blondelPhasorDiagram to clean up the phasor diagram plotting logic. (Class/blondelPhasorDiagram.m)

Code Quality and Maintenance

• Added comments and improved function documentation for easier understanding and maintainability. (Class/@MotorcadData/rawPsiDataPost.m, Class/motorcadResultPhasorDiagram.m) [1] [2] [3] [4]

Reference:
[1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]

[Copilot]

Pull request overview

This PR expands the codebase with new pyMotorGeo Python modules (contracts/bridges/face detection/CLI), Notion automation utilities, and MATLAB utilities for model fitting and MotorCAD/JMAG plotting—aiming to improve geometry analysis workflows and documentation/visualization tooling.

Changes:

• Added multiple new pyMotorGeo modules (contracts, face detection, symmetry reconstruction, MotorCAD/Pyleecan/FastAPI bridges, CLI entrypoints).
• Added Notion plan/database sync + seeding scripts, plus a git-to-Notion sync utility.
• Added/updated MATLAB utilities including BasisModel and plotting/phasor diagram adjustments.

Reviewed changes

Copilot reviewed 75 out of 2038 changed files in this pull request and generated 25 comments.

Show a summary per file

File	Description
Class/pyMotorGeo/topology_base.py	Adds abstract topology classifier base + geometry helpers
Class/pyMotorGeo/test_refactoring.py	Adds refactoring test runner-style checks for OOP/compat
Class/pyMotorGeo/sync_notion_plan_hierarchy.py	Adds markdown-to-Notion block hierarchy sync
Class/pyMotorGeo/sync_notion_plan_db.py	Adds markdown-to-Notion database upsert sync
Class/pyMotorGeo/sync_notion_from_git.py	Adds git latest-commit → Notion logging bridge
Class/pyMotorGeo/symmetry.py	Adds symmetry detection + half-unit extraction/reconstruction
Class/pyMotorGeo/seed_notion_role_tasks.py	Seeds role-separated rows in a Notion DB
Class/pyMotorGeo/requirements_api.txt	Adds FastAPI service dependencies list
Class/pyMotorGeo/pyleecan_subprocess_bridge.py	Adds subprocess bridge to run pyleecan in separate env
Class/pyMotorGeo/pyleecan_lock.json	Records pinned pyleecan env strategy/paths
Class/pyMotorGeo/pyleecan_env_runner.py	Adds external-env runner that writes JSON result bundle
Class/pyMotorGeo/plan.md	Adds Airgap recovery + docs alignment plan
Class/pyMotorGeo/plan-airgapRecoveryAndDocsAlignment.prompt.md	Adds prompt version of the recovery/alignment plan
Class/pyMotorGeo/patch_notion_collab_schema.py	Adds script to patch Notion DB schema
Class/pyMotorGeo/palantir_viz/src/puml_flow_animator.py	Adds PlantUML → animated GIF generator
Class/pyMotorGeo/palantir_viz/docs/ROADMAP.md	Adds roadmap for flow viz prototype
Class/pyMotorGeo/palantir_viz/README.md	Documents the flow viz prototype usage
Class/pyMotorGeo/motorcad_bridge.py	Adds DXF-face → MotorCAD region conversion + apply/export
Class/pyMotorGeo/geometry_bridge.py	Adds DXF/JSON → GeometryPayload(v1) conversion bridge
Class/pyMotorGeo/fix_imports.py	Adds script to rewrite relative imports to absolute
Class/pyMotorGeo/fastapi_inference_service.py	Adds FastAPI endpoint wrapping pyleecan subprocess bridge
Class/pyMotorGeo/face_detection.py	Adds shapely-based face detection + interior point logic
Class/pyMotorGeo/editor.py	Adds interactive region editor GUI + finalization helper
Class/pyMotorGeo/core.py	Adds core DTOs + rotation/mirror/transform utilities
Class/pyMotorGeo/contracts.py	Adds contract dataclasses + JSON dump/load helpers
Class/pyMotorGeo/contract_examples/ml_dataset_payload_v1.json	Adds ML dataset contract example
Class/pyMotorGeo/contract_examples/geometry_payload_v1.json	Adds geometry contract example
Class/pyMotorGeo/contract_examples/README.md	Documents contract example usage
Class/pyMotorGeo/cli.py	Adds CLI commands (analyze/info/version) for pyMotorGeo
Class/pyMotorGeo/analysis_base.py	Adds abstract base class for slot/pole counters
Class/pyMotorGeo/analysis.py	Adds analysis re-export hub for backward compatibility
Class/pyMotorGeo/agent_sync_logger.py	Adds Notion logging utility for agents/servers
Class/pyMotorGeo/main.py	Adds python -m pyMotorGeo entrypoint
Class/pyMotorGeo/init.py	Adds package exports and large __all__ list
Class/pyMotorGeo/NOTEBOOK_REFACTORING_RUN_REPORT_2026-03-31.md	Adds notebook run report
Class/pyMotorGeo/NOTEBOOK_FUNCTION_MIGRATION_PLAN.md	Adds notebook → package migration plan
Class/pyMotorGeo/NOTEBOOK_FUNCTION_INVENTORY.md	Adds baseline notebook function inventory
Class/pyMotorGeo.egg-info/top_level.txt	Adds egg-info metadata
Class/pyMotorGeo.egg-info/requires.txt	Adds egg-info dependency list
Class/pyMotorGeo.egg-info/entry_points.txt	Adds egg-info console_scripts entrypoint
Class/pyMotorGeo.egg-info/dependency_links.txt	Adds egg-info dependency links file
Class/pyMotorGeo.egg-info/SOURCES.txt	Adds egg-info sources list
Class/pyMotorGeo.egg-info/PKG-INFO	Adds egg-info package metadata
Class/motorcadResultPhasorDiagram.m	Comments out MotorCAD COM creation line
Class/blondelPhasorDiagram.m	Removes obsolete Blondel phasor diagram implementation
Class/UML_AND_ARCHITECTURE.md	Adds architecture guide markdown
Class/PLANTUML_SETUP_GUIDE.md	Adds PlantUML setup documentation
Class/Motorcad/fcnACLoss.m	Adds reference comment for default MotorCAD settings
Class/Jmag/@JmagData/phasor_diagram.m	Removes some redundant axis quiver calls
Class/Jmag/@JmagData/jmagFcnGraphExport.m	Fixes missing semicolon in CSV path assignment
Class/Jmag/@JmagData/JmagData.m	Updates default JMAG version string
Class/BasisModel.m	Adds basis-function surface fitting/evaluation model
Class/@MotorcadData/rawPsiDataPost.m	Adds comments/section headers
Class/@MotorcadData/exportRawLossMap.m	Removes stray blank/whitespace line
Class/@MotorcadData/devPlotMCADIronLossCoeffMap.m	Adds MotorCAD iron loss coefficient plotting function
Class/@DataDqMap/plot_xdyq.m	Fixes function name typo
.vscode/extensions.json	Adds recommended VS Code extensions
.github/copilot-instructions.md	Adds agent operating instructions

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

python -m ... lines are outside a string/comment, which makes this module a syntax error on import (the CLI will not run at all). Move these lines into the top docstring, or convert them to comments (prefix with #) and remove the stray triple-quote that re-opens/closes a string in the middle of the file.

[Copilot]

A Notion integration token is hard-coded in the repository. This is a credential leak and must be removed immediately (rotate/revoke the token) and loaded via environment variables or a secure secret store; also scrub git history if this was a real token.

Suggested change

	TOKEN = "ntn_f1882298252b4Hmvg4m6xIbT4qIv9wAIZiEDhxOoajQglM"
	import os
	TOKEN = os.environ.get("NOTION_INTEGRATION_TOKEN")
	if not TOKEN:
	raise RuntimeError(
	"NOTION_INTEGRATION_TOKEN environment variable is not set. "
	"Please configure a valid Notion integration token."
	)

[Copilot]

This uses PEP604 union syntax (str | None), which is invalid in Python 3.9. Your package metadata declares Requires-Python: >=3.9, so this will break installs/imports on supported versions. Either replace with Optional[str] (and update typing imports), or bump the project’s required Python version to >=3.10 everywhere consistently.

[Copilot]

Same Python-version incompatibility as above: str | None requires Python >=3.10 but package metadata indicates >=3.9. Use Optional[str] or update the package’s minimum Python version to >=3.10 and ensure all tooling/metadata is aligned.

[Copilot]

These type annotations use str | Path, which won’t parse on Python 3.9. This conflicts with Requires-Python: >=3.9. Replace with Union[str, Path] / Optional[...], or raise the minimum supported Python version across packaging metadata.

[Copilot]

"Github" should be "GitHub" to match standard naming and avoid creating inconsistent/duplicate multi-select options in Notion.

[Copilot]

"Github" should be "GitHub" to match standard naming and avoid creating inconsistent/duplicate multi-select options in Notion.

[Copilot]

The docstring claims ARC/CIRCLE are approximated using arc_n_pts, but the implementation currently ignores arc_n_pts and just uses ei.points as-is. Either implement the approximation here (if ei.points is not guaranteed to be densified), or update the docstring to reflect the actual behavior to prevent misleading API/docs.

[Copilot]

The docstring claims ARC/CIRCLE are approximated using arc_n_pts, but the implementation currently ignores arc_n_pts and just uses ei.points as-is. Either implement the approximation here (if ei.points is not guaranteed to be densified), or update the docstring to reflect the actual behavior to prevent misleading API/docs.

Suggested change

	ARC/CIRCLE은 arc_n_pts 점으로 근사합니다.
	점이 2개 미만이면 None 반환.
	ARC/CIRCLE 등의 곡선 엔티티는 이 함수에 전달되기 전에 이미 점 리스트(ei.points)
	형태로 근사되어 있다고 가정합니다. 여기서는 ei.points를 그대로 사용하며,
	arc_n_pts 인자는 현재 이 함수 내부에서는 사용하지 않고,
	상위 레벨에서의 호 근사 설정/호환성 유지를 위해서만 존재합니다.
	유효한 점이 2개 미만이면 None 을 반환합니다.

[Copilot]

The PR introduces multiple Python files using Python 3.10-only type syntax (PEP604 X | Y). If you keep those annotations, update packaging metadata (Requires-Python) to >=3.10 and ensure downstream tooling matches; otherwise, refactor those annotations to be Python 3.9-compatible. Keeping metadata and code version requirements consistent avoids install-time failures.

Suggested change

	Requires-Python: >=3.9
	Requires-Python: >=3.10