Repository navigation
fix: get Battle.net bots through Blizzard's security check - #121
Merged
Merged
Conversation
The choose page was marked as handled before the click, so a poll landing before the button rendered never asked for the code. Unknown pages with a text field are no longer taken for a code page, so the timeout diagnostic reports them, and a code being submitted is not asked for again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adding a Battle.net bot in production failed with "No answer from the login page in time": from a new device or IP, Blizzard puts two steps between the password and the ticket, and the login browser recognised neither.
/login/<locale>/challenge/<uuid>/choose): a method picker (<select>, "E-Mail" by default) with no text field. The browser now keeps the default method, clicks Submit and keeps waiting./login/<locale>/challenge/<uuid>,input[autocomplete=one-time-code]): now reported as "code required", so the admin's code field appears. The code is filled in; the page submits it by itself (Submit is clicked only if it is still there), then the usual ticket redirect follows.Module to restart
catapult-api.
Tests
fr.enimaloc.catapult.service.battlenet.login.*: newLoginPageInspectionTest(8) plus the existing coordinator, flow and browser tests — green. The full flow against Blizzard is validated in production with a single admin login once deployed.