Repository navigation
refactor: drop the service account label - #119
Merged
Merged
Conversation
A Minecraft service account is now shown by its Minecraft username: the label column is dropped (V111), the admin DTO carries a displayName, the device-code create no longer takes a label and the logs name the account by its username.
A Battle.net bot is now shown by its BattleTag, or before its first login by its masked e-mail (b***@example.com), computed in the admin DTO's displayName. The label column is dropped (V112), the create takes only the e-mail and the password, a PATCH ignores a legacy label, and logs and the session metrics name the bot by its account id.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drops the free-text "label" of the Minecraft and Battle.net service accounts; the admin shows the account's real identity instead.
minecraftUsername). The default label and the label input are gone.b***@example.com). Create takes{email, password}; the details form only edits the fill order.catapult.battlenet.session.replaced,catapult.battlenet.session.admin_action_required) are tagged by account id instead of the label; never by e-mail.labelstill sent by an older client is ignored.labelcolumns (existing labels are lost on deploy, as intended).Modules to restart
catapult-api and catapult-web, together (shared admin DTOs replaced
labelwithdisplayName).Before deploy
Any Grafana panel or alert outside this repo that filters these two Battle.net metrics by their
accounttag must switch from the label to the account id.Tests
Touched classes: catapult-api 250, catapult-web 416, vitest 26 — green. Route/access/budget checks are CI-only (no route changed).