Repository navigation
fix: show bindings pages whose bindings have no Twitch category - #117
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A bindings page whose bindings all lack a Twitch category made
/dashboardfail with a 500, which catapult-web shows as a 404.ChannelDashboardAssembler.boxArts()returnsMap.of()when no binding on the page has a Twitch category id, and callers then didboxArts.get(null): immutable maps throw aNullPointerExceptionon a null key (the non-empty case is aHashMap, which accepts it, so only such pages broke). Seen live with page 2 holding a single INCOMPLETE binding without a category. The single-binding path (current binding) had the same pattern.Fix: a small
boxArt(map, id)helper returning no box art for a binding without a category, used at both call sites.Tests
Two new tests in
ChannelDashboardAssemblerTestreproduce the NPE (page with only uncategorised bindings; current binding without a category); the whole class passes (51 tests).Modules to restart
catapult-api.