Find transitive closure of elements affected during assembly#99
Merged
Conversation
tomcur
changed the title
tomcur
changed the title
waywardmonkeys
approved these changes
Sep 17, 2025
When solving using a recursive assembly plan, elements we're now solving for may occur on one or more existing cluster's frontiers. The previous code correctly solves for those cluster's poses such that all clusters agree on those elements' global positions. However, the previous code does not take into account that changing one of those clusters' poses may move an element that we're not directly solving for, but which may itself occur on some cluster's frontier. That cluster will then also have to be moved, etc. Therefore, we need to solve for the transitive closure of all elements affected.
tomcur
force-pushed
the
frontier-transitive-closure
branch
from
b8e020d to
61a8715
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When solving using a recursive assembly plan, elements we're now solving for may occur on one or more existing cluster's frontiers. The previous code correctly solves for those cluster's poses such that all clusters agree on those elements' global positions.
However, the previous code does not take into account that changing one of those clusters' poses may move an element that we're not directly solving for, but which may itself occur on some other cluster's frontier. That cluster will then also have to be moved, etc.
Therefore, we need to solve for the transitive closure of all elements affected.
#97 passes once rebased on top of this.