Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the last commit: 8e127d6.
This starts thinking about utility construction methods, to expressively build geometry on top of other geometry. This is directly motivated to allow potentially dropping the current references system (where, e.g., a circle is constructed from a reference to a point and a reference to a length, and constraints can simultaneously be placed on the referenced point and the circle built on top of it).
These methods introduce a way of constructing the same kind of geometry through the normal constraint system. This can be more expressive, as it allows creating geometry that cannot be represented directly with references (e.g., something like
elements::Rectangle::point_at_top_right, where the rectangle is not represented by a point in that location). There is some cost, as references are "free": they represent the same variables, and thus their relationships are trivially true. On the other hand, references make degree-of-freedom analysis harder, thereby complicating system analysis and decomposition.For example, instead of the following.
You'd write the following.
We could also have methods like
elements::Line::create_through_points(&mut s, p1, p2).