fix: use helm dependency update and refresh stale Chart.lock - #7
Open
enchantednatures wants to merge 2 commits into
Open
fix: use helm dependency update and refresh stale Chart.lock#7enchantednatures wants to merge 2 commits into
enchantednatures wants to merge 2 commits into
Conversation
- Change helm dependency build to helm dependency update in lint-test.yaml to prevent stale Chart.lock from breaking CI - Update test-chart Chart.lock from ksvc 0.6.0 to 0.6.3
The test-chart uses file:// (local dep), so the lock file serves no reproducibility purpose and goes stale on every library version bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
helm dependency build→helm dependency updateinlint-test.yamlto prevent staleChart.lockfrom breaking CItest-chart/Chart.lockfrom ksvc0.6.0to0.6.3Context
The "Helm Unit Tests" CI job was failing because
Chart.lockwas pinned to ksvc0.6.0but the library chart is now at0.6.3.helm dependency buildreads the lock file and fails when the locked version doesn't match.Using
helm dependency updateinstead resolves the lock file at build time, making CI resilient to version bumps.