feat: add dynamic interface management to handle network disconnects #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breaking change release targeting: - Proper interfaces for testability - Dependency injection - Generated mocks - Improved test coverage - Removal of global state
- Add api/ package with PacketConn, ConnectionFactory, InterfaceProvider interfaces - Add mocks/ package with mockery-generated mocks for testing - Split connection.go into conn_factory.go, conn_ipv4.go, conn_ipv6.go, conn_provider.go - Rename connection.go to mdns.go (contains only mDNS constants) - Export Client type and add NewClient() constructor - Add WithClientConnFactory and WithServerConnFactory options for mock injection - Remove deprecated Server.TTL() method - Add comprehensive unit tests (87.6% coverage) - Update README with v3 examples and testing documentation - Bump version to v3.0.0 Breaking changes: - Browse() now requires a 'removed' channel parameter - Module path is github.com/enbility/zeroconf/v3
This change fixes infinite warning logs when network interfaces disconnect during mDNS operations. Previously, the code would continue attempting to send to disconnected interfaces, generating warnings on every attempt. Key changes: - Add InterfaceManager to track active/failed interfaces with adaptive backoff - Add error classification (isInterfaceGone) to detect interface failures - Update Client and Server to use InterfaceManager for dynamic iteration - Fix Windows conn wrappers to return errors instead of logging them - Add integration tests that simulate the original disconnect scenario The fix uses separate IPv4/IPv6 managers to prevent cross-protocol failure cascades. When an interface fails with ENXIO, ENETDOWN, or similar errors, it's immediately removed from the active set. Recovery is attempted with adaptive backoff (1s, 5s, 30s) when interfaces reappear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes infinite warning logs when network interfaces disconnect
during mDNS operations. Previously, the code would continue attempting to
send to disconnected interfaces, generating warnings on every attempt.
Key changes:
The fix uses separate IPv4/IPv6 managers to prevent cross-protocol failure
cascades. When an interface fails with ENXIO, ENETDOWN, or similar errors,
it's immediately removed from the active set. Recovery is attempted with
adaptive backoff (1s, 5s, 30s) when interfaces reappear.
This required the PR #3
It fixes #1