Repository navigation
Fix issue with glReadPixels() not taking into account the GL_PACK_ROW_LENGTH - #27243
Merged
juj merged 5 commits intoNov 19, 2026
Merged
Conversation
…_LENGTH, when WEBGL_USE_GARBAGE_FREE_APIS=false, e.g. in Wasm64 mode, due to https://crbug.com/324992397 and https://bugzil.la/1838218.
juj
enabled auto-merge (squash)
July 2, 2026 17:19
sbc100
approved these changes
Jul 3, 2026
Collaborator
|
Looks like you need to run |
…_pack_row_length # Conflicts: # src/struct_info.json # src/struct_info_generated.json
- Zero-initialize the buffer in the test with `= {0}` instead of
calling memset().
- Regenerate `struct_info_generated_wasm64.json`, which was missing the
new `GL_PACK_ROW_LENGTH` define (`other.test_gen_struct_info`).
- Refer to `GL_PACK_ROW_LENGTH` directly, the same way as the other GL
constants are now referred to since emscripten-core#28144.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
The glReadPixels() change adds 31 bytes of JS to this test. The Wasm size is not affected. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
juj
force-pushed
the
fix_webgl2_readpixels_pack_row_length
branch
from
November 19, 2026 12:17
cf841a0 to
6b934b5
Compare
Collaborator
Author
|
Ops, this PR fell in between. Updated it now to latest, though it looks like there's some kind of network outage on the CI. |
sbc100
reviewed
Nov 19, 2026
|
|
||
| @requires_webgl2 | ||
| def test_webgl2_readpixels(self): | ||
| self.btest_exit('webgl2_readpixels_pack_row_length.c', cflags=['-sMIN_WEBGL_VERSION=2']) |
Collaborator
There was a problem hiding this comment.
Can you rename either test method or the filename, so that they match?
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue with glReadPixels() not taking into account the GL_PACK_ROW_LENGTH, when WEBGL_USE_GARBAGE_FREE_APIS=false e.g. in Wasm64 mode, due to https://crbug.com/324992397 and https://bugzil.la/1838218 .