Skip to content

fix(core): correct parameter order in neu_req_del_tag_copy#2731

Merged
fengzeroz merged 1 commit intoemqx:mainfrom
ZhouBox:main
Apr 9, 2026
Merged

fix(core): correct parameter order in neu_req_del_tag_copy#2731
fengzeroz merged 1 commit intoemqx:mainfrom
ZhouBox:main

Conversation

@ZhouBox
Copy link
Copy Markdown
Contributor

@ZhouBox ZhouBox commented Apr 9, 2026

  • Fix reversed parameter order in neu_req_del_tag_copy call at manager.c:1488
  • Add missing return statement on strdup failure in neu_req_del_tag_copy function

- Fix reversed parameter order in neu_req_del_tag_copy call at manager.c:1488
- Add missing return statement on strdup failure in neu_req_del_tag_copy function
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.89%. Comparing base (a485bb6) to head (118dfc0).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
include/neuron/msg.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2731   +/-   ##
=======================================
  Coverage   64.88%   64.89%           
=======================================
  Files         125      125           
  Lines       30649    30650    +1     
=======================================
+ Hits        19888    19889    +1     
  Misses      10761    10761           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZhouBox ZhouBox requested a review from fengzeroz April 9, 2026 02:42
@fengzeroz fengzeroz merged commit 522db9f into emqx:main Apr 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants