Repository navigation
Adapt to meilisearch-go v0.36 API and upgrade all dependencies - #8
Merged
Merged
Conversation
meilisearch-go v0.35+ added a *DocumentOptions parameter to DeleteDocumentWithContext and DeleteAllDocumentsWithContext, breaking builds that resolve a newer version than the previous v0.34 pin. Pass nil to keep the existing behavior. Upgrades all direct and indirect module dependencies to latest (meilisearch-go v0.36.3, pgx v5.10.0, pglogrepl 2026-04, go-redis v9.22.0, sonic v1.15.2, cel-go, prometheus client, chi, gobreaker, fx/zap and friends), which also clears the vulnerable indirect versions flagged by Dependabot. Full test suite passes against the new versions, including the byte-level pgoutput decoder tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019dEj24Ta2o9QxzW9ZrSPtb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the build breakage against newer
meilisearch-goand brings every dependency up to date.The fix: meilisearch-go v0.35+ added a
*meilisearch.DocumentOptionsparameter toDeleteDocumentWithContextandDeleteAllDocumentsWithContext, so builds resolving anything newer than the previousv0.34.2pin failed with:Both call sites now pass
nil, preserving the existing behavior.The upgrade: all direct and indirect modules bumped to latest — meilisearch-go v0.36.3, pgx v5.10.0, a current pglogrepl, go-redis v9.22.0, sonic v1.15.2, cel-go, the Prometheus client, chi, gobreaker, and the fx/zap stack. This also replaces the vulnerable indirect versions behind the repo's open Dependabot alerts.
Type of change
Checklist
go test ./...passes (including-race) against the upgraded versions — notably the byte-level pgoutput decoder tests, which are the meaningful compatibility check for the pglogrepl bumpgofmt/go vetare cleanNotes for the reviewer
niloptions argument is the API's "no options" value; delete-by-id and delete-all behave exactly as before.git pull+go build -o gateway ./cmd/gatewayresolves the reported Windows build failure (rungo mod tidyfirst if a localgo.modhas drifted).🤖 Generated with Claude Code
https://claude.ai/code/session_019dEj24Ta2o9QxzW9ZrSPtb
Generated by Claude Code