Skip to content

Adapt to meilisearch-go v0.36 API and upgrade all dependencies - #8

Merged
emoss08 merged 1 commit into
mainfrom
claude/custom-cdc-review-zth3ax
Aug 11, 2026
Merged

emoss08 merged 1 commit into
mainfrom
claude/custom-cdc-review-zth3ax

Conversation

@emoss08

@emoss08 emoss08 commented Aug 11, 2026

Copy link
Copy Markdown
Owner

What does this PR do?

Fixes the build breakage against newer meilisearch-go and brings every dependency up to date.

The fix: meilisearch-go v0.35+ added a *meilisearch.DocumentOptions parameter to DeleteDocumentWithContext and DeleteAllDocumentsWithContext, so builds resolving anything newer than the previous v0.34.2 pin failed with:

internal\adapters\secondary\meilisearch\sink.go:124:53: not enough arguments in call to index.DeleteDocumentWithContext
        have (context.Context, string)
        want (context.Context, string, *"github.com/meilisearch/meilisearch-go".DocumentOptions)

Both call sites now pass nil, preserving the existing behavior.

The upgrade: all direct and indirect modules bumped to latest — meilisearch-go v0.36.3, pgx v5.10.0, a current pglogrepl, go-redis v9.22.0, sonic v1.15.2, cel-go, the Prometheus client, chi, gobreaker, and the fx/zap stack. This also replaces the vulnerable indirect versions behind the repo's open Dependabot alerts.

Type of change

  • Bug fix
  • New feature / sink
  • Documentation
  • Refactor / chore

Checklist

  • go test ./... passes (including -race) against the upgraded versions — notably the byte-level pgoutput decoder tests, which are the meaningful compatibility check for the pglogrepl bump
  • gofmt / go vet are clean
  • Tests added — no behavior change; existing coverage exercises the touched paths
  • Docs — no user-facing change
  • Delivery semantics untouched

Notes for the reviewer

  • The nil options argument is the API's "no options" value; delete-by-id and delete-all behave exactly as before.
  • After merging, a local git pull + go build -o gateway ./cmd/gateway resolves the reported Windows build failure (run go mod tidy first if a local go.mod has drifted).

🤖 Generated with Claude Code

https://claude.ai/code/session_019dEj24Ta2o9QxzW9ZrSPtb


Generated by Claude Code

meilisearch-go v0.35+ added a *DocumentOptions parameter to
DeleteDocumentWithContext and DeleteAllDocumentsWithContext, breaking
builds that resolve a newer version than the previous v0.34 pin. Pass
nil to keep the existing behavior.

Upgrades all direct and indirect module dependencies to latest
(meilisearch-go v0.36.3, pgx v5.10.0, pglogrepl 2026-04, go-redis
v9.22.0, sonic v1.15.2, cel-go, prometheus client, chi, gobreaker,
fx/zap and friends), which also clears the vulnerable indirect versions
flagged by Dependabot. Full test suite passes against the new versions,
including the byte-level pgoutput decoder tests.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019dEj24Ta2o9QxzW9ZrSPtb
@emoss08
emoss08 merged commit 08cd13c into main Aug 11, 2026
2 checks passed
@emoss08
emoss08 deleted the claude/custom-cdc-review-zth3ax branch August 11, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants