Binary & Prob Geotiff#87
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors GeoTIFF generation functionality to allow creating both binary and probability cloud masks in a single operation, eliminating the need for separate function calls. The change consolidates duplicate code and improves the user experience by generating both mask types when probability output is requested.
Key Changes:
- Created a centralized
make_geotifffunction that can generate both binary and probability masks - Refactored deployment modules to use the new consolidated function
- Updated help text to reflect that probability option now generates both mask types
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| spectf_cloud/deploy/gen_geotiff.py | New module containing consolidated GeoTIFF generation logic with support for dual mask creation |
| spectf_cloud/deploy/deploy_trt.py | Refactored to use centralized GeoTIFF function and removed duplicate code |
| spectf_cloud/deploy/deploy_pt.py | Refactored to use centralized GeoTIFF function and updated help text |
jakehlee
requested changes
Aug 22, 2025
jakehlee
left a comment
Collaborator
There was a problem hiding this comment.
Great idea consolidating the GeoTIFF export to a single function, I left some minor comments. Thanks!
jakehlee
added a commit
that referenced
this pull request
Sep 10, 2025
Merging based on approval of #87 for release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR is to allow for the creation of a binary cloud mask in addition to a probability mask, so that way 2 separate calls aren't needed.
Related Tickets
resolves #86
Testing