Sprint_2 #4
Open
Sprint_2 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayantea1
reviewed
Jul 23, 2025
tests_books_collector.py
Outdated
|
|
||
| class TestBooksCollector: | ||
| #Фикстура collector - создает новый экземпляр класса для каждого теста | ||
| @pytest.fixture |
There was a problem hiding this comment.
можно улучшить: фикстуру стоит вынести в отдельный модуль
Ayantea1
reviewed
Jul 23, 2025
| assert collector.get_list_of_favorites_books() == ['Скотный двор', 'Мы'] | ||
|
|
||
| # Проверяем что метод get_book_genre возвращает правильный жанр | ||
| def test_get_book_genre(self, collector): |
There was a problem hiding this comment.
Нужно исправить: тест аналогичен set_book_genre. Попробуй установить значение жанра иначе, или иначе получить его для сравнения. Используй доступ к словарю. В идеале - в каждом тесте нужно использовать только один проверяемый метод
Ayantea1
reviewed
Jul 23, 2025
| ]) | ||
| def test_add_new_book(self, collector, name, expected): | ||
| collector.add_new_book(name) | ||
| assert (name in collector.get_books_genre()) == expected |
There was a problem hiding this comment.
Нужно исправить: нужны отдельные тесты для add_new_book и get_books_genre()
added 3 commits
July 23, 2025 15:45
…k_genre, фикстура вынесена в файл
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлен README и тесты для BooksCollector