feat(index): resolve parent_id via line-range containment#229
Merged
Conversation
Two-pass insert_symbols: first pass inserts with NULL parent_id and collects metadata, second pass resolves parent names by matching name + smallest enclosing line range. Backwards-compatible — plugins that don't emit parent field work exactly as before. Prepares chibi-core for language plugins that emit parent-child symbol hierarchies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
insert_symbolsinindexer.rs: first pass inserts all symbols withparent_id = NULL, second pass resolves parent names by matching name + smallest enclosing line rangeparentwork exactly as beforelang_rust)Test Plan
insert_symbols_resolves_parent_id— verifies struct/impl disambiguation via line-range containmentinsert_symbols_no_parent_still_works— backwards compat: no parent field → parent_id stays NULLinsert_symbols_unresolvable_parent_stays_null— unmatched parent name → graceful NULL + eprintln warning