fix(admin): add search to the byline picker and remove the 100-byline cap#1225
Draft
scottbuscemi wants to merge 1 commit into
Draft
fix(admin): add search to the byline picker and remove the 100-byline cap#1225scottbuscemi wants to merge 1 commit into
scottbuscemi wants to merge 1 commit into
Conversation
… cap The content-entity byline picker was a plain Select over the first 100 bylines with no search, so bylines past the first page were unreachable and a credited byline outside that page failed to render at all. Replace it with a debounced server-side search (fetchBylines already supports search + cursor) and resolve credited bylines from the saved entry so they always render. Closes #1217.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | 8681f73 | May 29 2026, 10:38 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-demo-cache | 8681f73 | May 29 2026, 10:39 PM |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
emdash-playground | 8681f73 | May 29 2026, 10:39 PM |
Contributor
PR template validation failedPlease fix the following issues by editing your PR description:
See CONTRIBUTING.md for the full contribution policy. |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1217.
Problem
On a content entity, the Bylines field rendered a plain
Selectpopulated from the first 100 bylines (fetchBylines({ limit: 100 })) with no search. With more than ~30 bylines it was hard to find the right one; past 100 they were unreachable. A credited byline outside that initial page also failed to render (the row resolvedundefinedand returnednull).Fix
Selectwith a debounced (300ms) server-side search input.fetchBylinesalready supportssearch+ cursor pagination, so any byline is reachable. The query isenabledonly when a search term is present, so there's no extra fetch on mount (the parent-provided initial list is reused when the box is empty).item.bylines[].byline) via a newselectedBylineDetailsprop, merged into a known-byline cache, so a credit outside the initial list still renders its name/slug.Testing
pnpm lint:quickclean;pnpm --filter @emdash-cms/admin typecheckpasses.packages/admin/tests/components/ContentEditor.test.tsx: (1) searching surfaces a byline outside the initial list and crediting it works; (2) a credited byline absent from the initial list still renders. These run in the browser (Playwright) test project — validated in CI (couldn't launch a local browser in this environment).Manual verification