Skip to content

Fix lint tooling and isolate type-aware config #1108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
richardjoo wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix lint tooling and isolate type-aware config #1108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b15ce6
Fix lint tooling and isolate type-aware config
richardjoo May 19, 2026
b5ac803
Chore: remove unused e18e lint plugin
richardjoo May 19, 2026
cc7a4e1
Sync lint tooling branch with main
richardjoo May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 2 additions & 21 deletions .oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"$schema": "./node_modules/oxlint/configuration_schema.json",
"plugins": ["typescript", "import", "unicorn", "promise"],
"jsPlugins": ["@e18e/eslint-plugin"],
"categories": {
Comment on lines 2 to 4
Copy link
Copy Markdown
Contributor Author

@richardjoo richardjoo May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the jsPlugins integration from .oxlintrc.json, @e18e/eslint-plugin was no longer used anywhere in the repo.

I removed it from package.json and updated the lockfile so the branch no longer installs an unused dependency.

"correctness": "error",
"suspicious": "warn",
Expand Down Expand Up @@ -29,33 +28,15 @@
{
"allow": ["**/*.css", "@testing-library/react", "vitest-browser-react"]
}
],
"e18e/prefer-array-at": "error",
"e18e/prefer-array-fill": "error",
"e18e/prefer-includes": "error",
"e18e/prefer-array-to-reversed": "error",
"e18e/prefer-array-to-sorted": "error",
"e18e/prefer-array-to-spliced": "error",
"e18e/prefer-nullish-coalescing": "error",
"e18e/prefer-object-has-own": "error",
"e18e/prefer-spread-syntax": "error",
"e18e/prefer-url-canparse": "error",
"e18e/ban-dependencies": "error",
"e18e/prefer-array-from-map": "error",
"e18e/prefer-timer-args": "error",
"e18e/prefer-date-now": "error",
"e18e/prefer-regex-test": "error",
"e18e/prefer-array-some": "error",
"e18e/prefer-static-regex": "error"
]
},
"overrides": [
{
"files": ["**/*.test.ts", "**/*.test.tsx", "**/tests/**/*.ts", "**/tests/**/*.tsx"],
"rules": {
"typescript/no-unsafe-type-assertion": "off",
"typescript/no-unnecessary-type-assertion": "off",
"unicorn/consistent-function-scoping": "off",
"e18e/prefer-static-regex": "off"
"unicorn/consistent-function-scoping": "off"
}
},
{
Expand Down
7 changes: 3 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@
"format": "oxfmt --ignore-path .gitignore && prettier --write .",
"format:check": "oxfmt --ignore-path .gitignore --check && prettier --check .",
"format:astro": "prettier --write .",
"lint": "oxlint --type-aware",
"lint": "oxlint --type-aware --tsconfig tsconfig.oxlint.json",
"lint:quick": "oxlint -f json",
"lint:json": "oxlint --type-aware -f json",
"lint:fix": "oxlint --type-aware --fix",
"lint:json": "oxlint --type-aware --tsconfig tsconfig.oxlint.json -f json",
"lint:fix": "oxlint --type-aware --tsconfig tsconfig.oxlint.json --fix",
"knip": "knip --no-exit-code --exclude unlisted,unresolved,exports,types,duplicates",
"new": "create-emdash",
"screenshots": "node scripts/screenshot-all-templates.mjs",
Expand All @@ -37,7 +37,6 @@
"@axe-core/playwright": "^4.11.1",
"@changesets/changelog-github": "^0.5.2",
"@changesets/cli": "^2.29.8",
"@e18e/eslint-plugin": "^0.2.0",
"@lunariajs/core": "https://pkg.pr.new/lunariajs/lunaria/@lunariajs/core@83617cc",
"@playwright/test": "^1.58.0",
"@types/node": "catalog:",
Expand Down
6 changes: 3 additions & 3 deletions packages/plugin-cli/src/commands/info.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@ export const infoCommand = defineCommand({
);
}

const name = profile?.name ?? result.slug;
const description = profile?.description;
const license = profile?.license;
const name = typeof profile?.name === "string" ? profile.name : result.slug;
const description = typeof profile?.description === "string" ? profile.description : undefined;
const license = typeof profile?.license === "string" ? profile.license : undefined;

console.log();
console.log(pc.bold(name));
Expand Down
8 changes: 6 additions & 2 deletions packages/plugin-cli/src/commands/search.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,12 @@ export const searchCommand = defineCommand({
for (const pkg of result.packages) {
// `pkg.profile` is lexicon-validated by DiscoveryClient (or null).
const profile = pkg.profile;
console.log(`${pc.bold(profile?.name ?? pkg.slug)} ${pc.dim(`(${pkg.slug})`)}`);
if (profile?.description) console.log(` ${profile.description}`);
const slug = typeof pkg.slug === "string" ? pkg.slug : "";
const name = typeof profile?.name === "string" ? profile.name : slug;
const description =
typeof profile?.description === "string" ? profile.description : undefined;
console.log(`${pc.bold(name)} ${pc.dim(`(${slug})`)}`);
if (description) console.log(` ${description}`);
console.log(` ${pc.dim(pkg.uri)}`);
console.log();
}
Expand Down
2 changes: 1 addition & 1 deletion packages/registry-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"build": "tsdown",
"dev": "tsdown --watch",
"prepublishOnly": "node --run build",
"typecheck": "tsgo --noEmit",
"typecheck": "tsc --noEmit",
"test": "vitest run",
"check": "publint && attw --pack --ignore-rules=cjs-resolves-to-esm --ignore-rules=no-resolution"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/registry-client/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"compilerOptions": {
"outDir": "./dist",
"rootDir": "./src",
"lib": ["es2023", "esnext.typedarrays"],
"lib": ["es2023"],
"types": ["node"]
},
"include": ["src/**/*"],
Expand Down
20 changes: 0 additions & 20 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 17 additions & 0 deletions tsconfig.oxlint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"extends": "./tsconfig.json",
"exclude": [
"**/node_modules/**",
"**/dist/**",
"**/.astro/**",
"**/.wrangler/**",
"**/*.d.ts",
"**/*.d.mts",
"**/*.d.cts",
"**/src/generated/**",
"skills/**/scaffold/**",
".agents/skills/**/scaffold/**",
".claude/skills/**/scaffold/**",
"scripts/query-dumps/**"
]
}
Loading