Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements Equation 50-17 from the SFPE Handbook, which calculates stairwell temperature for untreated pressurization air in smoke control systems.
Changes:
- Adds Equation 50-17 implementation for calculating stairwell temperature based on outdoor temperature, heat transfer factor, and building temperature
- Includes Rust implementation with test coverage and Python bindings with comprehensive documentation
- Updates module declarations and Sphinx documentation to expose the new equation
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
crates/sfpe_handbook/src/chapter_50/equation_50_17.rs |
New Rust implementation of stairwell temperature calculation with test coverage |
crates/sfpe_handbook/src/chapter_50/equation_50_16.rs |
Adds missing newline at end of file |
crates/sfpe_handbook/src/chapter_50.rs |
Adds module declaration for equation_50_17 |
crates/python_api/src/sfpe_handbook/chapter_50/equation_50_17.rs |
Python bindings with comprehensive docstring including LaTeX equation and usage example |
crates/python_api/src/sfpe_handbook/chapter_50.rs |
Integrates equation_50_17 module into chapter_50 Python module |
crates/python_api/docs/api/sfpe-handbook.rst |
Adds Sphinx documentation entry for Equation 50.17 |
crates/python_api/src/sfpe_handbook/chapter_50/equation_50_17.rs
Outdated
Show resolved
Hide resolved
crates/python_api/src/sfpe_handbook/chapter_50/equation_50_17.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
JamieMaclean
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.