Skip to content

Finishes 50-17 of SFPE Handbook#60

Merged
JamieMaclean merged 5 commits intomainfrom
add_sfpe_50-17
Jan 16, 2026
Merged

Finishes 50-17 of SFPE Handbook#60
JamieMaclean merged 5 commits intomainfrom
add_sfpe_50-17

Conversation

@simonsantama
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings January 16, 2026 17:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements Equation 50-17 from the SFPE Handbook, which calculates stairwell temperature for untreated pressurization air in smoke control systems.

Changes:

  • Adds Equation 50-17 implementation for calculating stairwell temperature based on outdoor temperature, heat transfer factor, and building temperature
  • Includes Rust implementation with test coverage and Python bindings with comprehensive documentation
  • Updates module declarations and Sphinx documentation to expose the new equation

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
crates/sfpe_handbook/src/chapter_50/equation_50_17.rs New Rust implementation of stairwell temperature calculation with test coverage
crates/sfpe_handbook/src/chapter_50/equation_50_16.rs Adds missing newline at end of file
crates/sfpe_handbook/src/chapter_50.rs Adds module declaration for equation_50_17
crates/python_api/src/sfpe_handbook/chapter_50/equation_50_17.rs Python bindings with comprehensive docstring including LaTeX equation and usage example
crates/python_api/src/sfpe_handbook/chapter_50.rs Integrates equation_50_17 module into chapter_50 Python module
crates/python_api/docs/api/sfpe-handbook.rst Adds Sphinx documentation entry for Equation 50.17

@JamieMaclean JamieMaclean merged commit 5dd48d7 into main Jan 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants