Adds equations 50-18, 50-19 and 50-20 of the SFPE handbook. #58
Merged
simonsantama merged 21 commits intomainfrom Jan 15, 2026
Merged
Adds equations 50-18, 50-19 and 50-20 of the SFPE handbook. #58simonsantama merged 21 commits intomainfrom
simonsantama merged 21 commits intomainfrom
Conversation
Contributor
Author
|
@JamieMaclean do not review yet. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds three new equations from Chapter 50 of the SFPE Handbook: equations 50-18, 50-19, and 50-20. It also adds documentation cross-referencing these equations with similar calculations in other fire engineering documents, and introduces dependencies to the fire_dynamics_tools crate.
Changes:
- Implements equation 50-18 for fractional effective dose (FED) calculation with time-varying concentrations
- Implements equations 50-19 and 50-20 for flow area factor calculations (identical implementations to existing equation 50-16)
- Adds cross-reference documentation linking equation 50-18 with CIBSE Guide E equation 10-8 as similar FED calculations
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/sfpe_handbook/src/chapter_50/equation_50_18.rs | New FED calculation equation with vector inputs for time-varying concentrations |
| crates/sfpe_handbook/src/chapter_50/equation_50_19.rs | New flow area factor equation (duplicate implementation of equation 50-16) |
| crates/sfpe_handbook/src/chapter_50/equation_50_20.rs | New flow area factor equation (duplicate implementation of equation 50-16) |
| crates/sfpe_handbook/src/chapter_50.rs | Module declarations for the three new equation modules |
| crates/python_api/docs/guide/equation-relationships.rst | Documentation cross-referencing FED equations across different standards |
| crates/fire_dynamics_tools/Cargo.toml | Adds unused dependencies for sfpe_handbook and cibse_guide_e |
| Cargo.lock | Updated dependency graph |
Contributor
hahaha. Sorry. I got the ping in emails because you mentioned me and I assumed that it was ready 🤦. My bad. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
crates/python_api/src/sfpe_handbook/chapter_50/equation_50_18.rs
Outdated
Show resolved
Hide resolved
crates/python_api/src/sfpe_handbook/chapter_50/equation_50_18.rs
Outdated
Show resolved
Hide resolved
crates/python_api/src/sfpe_handbook/chapter_50/equation_50_19.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
crates/python_api/src/sfpe_handbook/chapter_50/equation_50_18.rs
Outdated
Show resolved
Hide resolved
| /// - :math:`FED` is the fractional effective dose (dimensionless) | ||
| /// - :math:`C_i` is the mass concentration of material burned at the end of time interval i (g/m³) | ||
| /// - :math:`\Delta t_i` is the time interval i (s) | ||
| /// - :math:`LC_{t50}` is the lethal exposure dose from test data (mg/m³ or ppm) |
Contributor
There was a problem hiding this comment.
Suggested change
| /// - :math:`LC_{t50}` is the lethal exposure dose from test data (mg/m³ or ppm) | |
| /// - :math:`LCt_{50}` is the lethal exposure dose from test data (mg/m³ or ppm) |
crates/python_api/src/sfpe_handbook/chapter_50/equation_50_18.rs
Outdated
Show resolved
Hide resolved
crates/python_api/src/sfpe_handbook/chapter_50/equation_50_19.rs
Outdated
Show resolved
Hide resolved
crates/python_api/src/sfpe_handbook/chapter_50/equation_50_19.rs
Outdated
Show resolved
Hide resolved
crates/python_api/src/sfpe_handbook/chapter_50/equation_50_20.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jamie Maclean <38719252+JamieMaclean@users.noreply.github.com>
JamieMaclean
approved these changes
Jan 15, 2026
Co-authored-by: Jamie Maclean <38719252+JamieMaclean@users.noreply.github.com>
Co-authored-by: Jamie Maclean <38719252+JamieMaclean@users.noreply.github.com>
Co-authored-by: Jamie Maclean <38719252+JamieMaclean@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross references with similar equations in other books